fix broken macOS paths for homebrew service #7189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Spacemacs is run as a macOS homebrew service, the window-system at startup time is not set. This causes the very-early call to exec-path-from-shell, which was checking for macOS via window-system, to fail the check. This is pretty much game over for macOS and user-customized paths, as the exec paths are not updated and any extra user-path utilities (e.g. aspell, gls) won't be found. This change switches over to using spacemacs/system-is-mac and spacemacs/system-is-linux as the primary check, and keeps the window-system check for 'x in case other Unix variants are getting exec-path set via that check.
|
I'm a bit confused on which branch to base this on. I used the 'develop' branch/tag as the initial PR request header message said to not use master and to use the 'development' branch (which isn't a named branch in the repo). However, I see a lot of activity on the master branch, and the develop seems quite stale. Please let me know if I need to rebase this against a different one. Thanks for all the excellent work on Spacemacs! |
|
|
|
Thanks, @nixmaniack! |
|
Thanks! Cherry-picked in develop. You can safely delete your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Spacemacs is run as a macOS homebrew service, the window-system at startup time is not set as it is running essentially headless. This causes the very-early call to exec-path-from-shell, which was checking for macOS via window-system, to fail the check. This is pretty much game over for macOS and user-customized paths, as the exec paths are not updated and any extra user-path utilities (e.g. aspell, gls) won't be found.
This change switches over to using spacemacs/system-is-mac and spacemacs/system-is-linux as the primary checks, and keeps the window-system check for 'x in case other Unix variants are getting exec-path set via that check.