Process user-config before command line arguments #7202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emacs-startup-hook is run after the command line arguments are being processed (and not at all if in batch mode). This has several undesired side-effects. If Emacs is started with file arguments, user-config is being run after the respective major mode has been initialized. Thus, variables set and code defined in user-config will not have the desired effect in that particular scenario. Also, in batch mode, user-config will not be evaluated at all which in some cases is not what the user might want and/or expect. This refactors the handling of user-config to the after-init-hook and introduces another needed setup function for init.el.
|
@Miciah I'm using the latest version of spacemacs, but I still experience this issue. In particular, I have this code in my (add-hook 'json-mode-hook 'prettier-js-mode)…and prettier-js-mode is correctly enabled if I C-x C-f to a .json file, but not if I invoke spacemacs with If, however, I move the code to |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this PR is still need merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emacs-startup-hook is run after the command line arguments are being processed (and not at all if in batch mode). This has several undesired side-effects. If Emacs is started with file arguments, user-config is being run after the respective major mode has been initialized. Thus, variables set and code defined in user-config will not have the desired effect in that particular scenario. Also, in batch mode, user-config will not be evaluated at all which in some cases is not what the user might want and/or expect.
This refactors the handling of user-config to the after-init-hook and introduces another needed setup function for init.el.