Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

better-defaults layer: update emacs logo #7300

Closed

Conversation

deb0ch
Copy link
Contributor

@deb0ch deb0ch commented Oct 6, 2016

The new emacs logo just looks better 馃槣

Btw, I copy/pasted the image file from the emacs-lisp layer, relying on git to detect duplication and avoid uselessly wasted memory.

I don't know if that is the best approach, but I also didn't find a clean way of sharing that picture between the two layers.

@houli
Copy link
Contributor

houli commented Oct 6, 2016

@deb0ch
Copy link
Contributor Author

deb0ch commented Oct 6, 2016

Hmmm I thought that it was it 馃槄
It looked newish and all with the flat design. And I prefer that version over the old one even if it's not the official, but that's beside the point.

What is this logo that is in the emacs-lisp layer then ?

And how should we go about it, replace them both by the new logo, leave it like that or accept this PR ?

@TheBB
Copy link
Collaborator

TheBB commented Oct 8, 2016

The emacs lisp layer logo is also the old one, note how the E points slightly more upwards in the new. Please replace both of them with the new one.

@JAremko
Copy link
Collaborator

JAremko commented Oct 8, 2016

The new emacs logo just looks better 馃槣

But the first one takes 10X more work to make. Go figure. 馃槙

@deb0ch deb0ch force-pushed the PR/better-defaults-update-logo branch from 4fbaec5 to 564e1a9 Compare October 9, 2016 13:53
@deb0ch
Copy link
Contributor Author

deb0ch commented Oct 9, 2016

Done 馃槃

@JAremko Got more efficient 馃槢

@JAremko
Copy link
Collaborator

JAremko commented Oct 9, 2016

@deb0ch I'll try 馃槹

Why I rad it as get .. Mb subconscious self trying to tell me something. Can't quite get it. 馃槙

@TheBB
Copy link
Collaborator

TheBB commented Oct 17, 2016

Thanks! Cherry-picked in develop. You can safely delete your branch.

@TheBB TheBB closed this Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants