[elixir] Add missing Alchemist commands and key bindings #8746
Conversation
layers/+lang/elixir/packages.el
Outdated
| "tf" 'alchemist-test-file | ||
| "tn" 'alchemist-test-jump-to-next-test | ||
| "tp" 'alchemist-test-jump-to-previous-test | ||
| "tT" 'alchemist-project-run-tests-for-current-file |
There was a problem hiding this comment.
What is the difference with alchemist-mix-test-file ?
There was a problem hiding this comment.
alchemist-mix-test-file will ask to choose which test file to run.
alchemist-project-run-tests-for-current-file will run tests for this file - if it cannot find the tests, it will ask whether to create it (y/n) and then create the corresponding file and open it in a new window for writing.
| "oi" 'alchemist-macroexpand-once-region | ||
| "oI" 'alchemist-macroexpand-once-print-region | ||
| "or" 'alchemist-macroexpand-region | ||
| "oR" 'alchemist-macroexpand-print-region) |
There was a problem hiding this comment.
I don't know how macroexpand works for elixir but do you think this could be similar to macrostep for elisp ?
https://github.com/syl20bnr/spacemacs/blob/develop/layers/+lang/emacs-lisp/packages.el#L164-L175
There was a problem hiding this comment.
My understanding is that the elixir macroexpand is not interactive, it is meant to be "expand once" or "expand completely" for different region sizes and with optional "printing" (appending below the current region as comments).
e.g. :
|
Also, do we really need the maintenance of |
layers/+lang/elixir/packages.el
Outdated
| @@ -91,10 +93,13 @@ | |||
| "ta" 'alchemist-mix-test | |||
| "tb" 'alchemist-mix-test-this-buffer | |||
| "tt" 'alchemist-mix-test-at-point | |||
| "tf" 'alchemist-mix-test-file | |||
| "tf" 'alchemist-project-run-tests-for-current-file | |||
There was a problem hiding this comment.
Please note this breaking change... my goal was to make the key bindings more intuitive.
It was a nice addition but you are right, we can delete them as they don't fit with the standard of Spacemacs so it feels weird to have this for only language. |
|
@syl20bnr I have updated the PR to remove the I have been using this patch successfully for a few weeks now and have no issues so far. Please let me know if any other changes are needed. Thanks! |
layers/+lang/elixir/README.org
Outdated
| @@ -201,10 +206,39 @@ You find and overview of all the key-bindings on the [[https://github.com/tonini | |||
| | ~SPC m x :~ | Run a custom execute command with =elixir= | | |||
| | ~SPC m x b~ | Run the current buffer through =elixir= | | |||
| | ~SPC m x f~ | Run =elixir= with the given filename | | |||
|
|
|||
There was a problem hiding this comment.
One new line after a table is required 
https://travis-ci.org/syl20bnr/spacemacs/jobs/232505130#L478
|
@swaroopch |
|
@swaroopch this PR has conflict 😢 |
Commands and key bindings found via `alchemist-refcard` command. I've tried to adhere to Spacemacs conventions but where I couldn't find relevant conventions, I followed Alchemist's key bindings. Also, delete alchemist-refcard - approved by @syl20bnr at #8746 (comment)
|
@JAremko Rebased. |
|
Thanks! Cherry-picked in develop. You can safely delete your branch. |
Commands and key bindings found via `alchemist-refcard` command. I've tried to adhere to Spacemacs conventions but where I couldn't find relevant conventions, I followed Alchemist's key bindings. Also, delete alchemist-refcard - approved by @syl20bnr at #8746 (comment)
Commands and key bindings found via `alchemist-refcard` command. I've tried to adhere to Spacemacs conventions but where I couldn't find relevant conventions, I followed Alchemist's key bindings. Also, delete alchemist-refcard - approved by @syl20bnr at syl20bnr#8746 (comment)
Commands and key bindings found via
alchemist-refcardcommand.I've tried to adhere to Spacemacs conventions but where I couldn't find relevant
conventions, I followed Alchemist's key bindings.