fix: oci: use correct bind options for user /dev[/xxx] binds (release-4.0) #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preminger
approved these changes
Nov 10, 2023
…-4.0) Cherry-pick sylabs#2328 When a user requests a bind of all of `/dev`, or a single `/dev/xxx` device, into the container it is because they wish to use a device. Prior to this PR, OCI-mode was binding `/dev` sources into the container with `nodev` set as a flag. Therefore e.g. `-B /dev/fuse` did not result in a usable FUSE device in the container. Modify the code so it behaves like native mode. A user request to bind all of `/dev` is treated in the same way as the full `/dev` mount with `--no-compat`. A user request to bind a single `/dev/xxx` entry is performed with logic and flags for dev entries specifically. Fixes sylabs#2326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Cherry-pick #2328
When a user requests a bind of all of
/dev, or a single/dev/xxxdevice, into the container it is because they wish to use a device.Prior to this PR, OCI-mode was binding
/devsources into the container withnodevset as a flag. Therefore e.g.-B /dev/fusedid not result in a usable FUSE device in the container.Modify the code so it behaves like native mode. A user request to bind all of
/devis treated in the same way as the full/devmount with--no-compat. A user request to bind a single/dev/xxxentry is performed with logic and flags for dev entries specifically.This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).