New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tar file creation reproducible #1083

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@bmwiedemann
Contributor

bmwiedemann commented Oct 22, 2017

in order to make package builds reproducible.
See https://reproducible-builds.org/ for why this is good.

Requires GNU tar-1.28 or later to be reproducible
Using gzip -n to not add a timestamp to the .gz header
OTOH I'm not sure if it was really intended to use gzip, because the file is just named .tar and very small anyway - then we could just call tar cf

Make tar file creation reproducible
in order to make package builds reproducible.
See https://reproducible-builds.org/ for why this is good.

Requires GNU tar-1.28 or later to be reproducible
Using gzip -n to not add a timestamp to the .gz header
@GodloveD

This looks good to me. I'm going to ask for a second opinion from @yhcote.

@GodloveD

This comment has been minimized.

Show comment
Hide comment
@GodloveD

GodloveD Oct 26, 2017

Member

@yhcote Agrees that this looks fine so I am merging.

Member

GodloveD commented Oct 26, 2017

@yhcote Agrees that this looks fine so I am merging.

@GodloveD GodloveD merged commit c469f5f into sylabs:master Oct 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GodloveD

This comment has been minimized.

Show comment
Hide comment
@GodloveD

GodloveD Oct 26, 2017

Member

I'm sorry @bmwiedemann. I stupidly forgot to check if this PR was against development or master and I merged into master. Then I had to revert. Can you please send this PR to development instead? Thank you.

Member

GodloveD commented Oct 26, 2017

I'm sorry @bmwiedemann. I stupidly forgot to check if this PR was against development or master and I merged into master. Then I had to revert. Can you please send this PR to development instead? Thank you.

@bmwiedemann bmwiedemann referenced this pull request Oct 27, 2017

Closed

Make tar file creation reproducible #1102

4 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment