loop: Use LOOP_CTL_ADD instead of mknod for dev creation #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wobito
approved these changes
Apr 6, 2023
Perform loop device creation via the LOOP_CTL_ADD ioctl against /dev/loop-control. This avoids hitting an error in the latest kernels that include a change in handling of loop device creation when max_loop is unset. Our target distros now all provide /dev/loop-control, so we are free to make this change. Also contains minor fixes to correct an error/debug message, and add an earlier continue in case of failure to open loop device in attachLoop. Fixes sylabs#1499
This was referenced Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Perform loop device creation via the LOOP_CTL_ADD ioctl against /dev/loop-control.
This avoids hitting an error in the latest kernels that include a change in handling of loop device creation when max_loop is unset.
Our target distros now all provide /dev/loop-control, so we are free to make this change.
Also contains minor fixes to correct an error/debug message, and add an earlier continue in case of failure to open loop device in attachLoop.
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).