Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in GMM caused by spelling mistake #64

Closed
ablaom opened this issue Jan 9, 2024 · 1 comment
Closed

Bug in GMM caused by spelling mistake #64

ablaom opened this issue Jan 9, 2024 · 1 comment

Comments

@ablaom
Copy link

ablaom commented Jan 9, 2024

Picked this up in an integration test:

BetaML.jl/src/GMM/GMM_MLJ.jl

Line 325 in df11d62

MMI.fitted_params(model::GaussianMixtureClusterer, fitresult) = (weights=fitesult.pₖ, mixtures=fitresult.mixtures)

fitesult should be fitresult
@ablaom ablaom mentioned this issue Jan 10, 2024
Closed
sylvaticus added a commit that referenced this issue Jan 11, 2024
@sylvaticus
Correct typo in MLJ fitted_params
f6f504e 
Solves #64 and #65
@ablaom
Copy link
Author

ablaom commented Jan 14, 2024

Thank you.

@ablaom ablaom mentioned this issue Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sylvaticus @ablaom