Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ModelDescriptors.toml for BetaML models #1090

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

sylvaticus
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (418402f) 57.89% compared to head (36c56b0) 57.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1090   +/-   ##
=======================================
  Coverage   57.89%   57.89%           
=======================================
  Files           2        2           
  Lines          38       38           
=======================================
  Hits           22       22           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the prompt attention to this detail, @sylvaticus.

As doc-generation is suppressed in PR's onto dev, the final test will be in the dev -> master branch. Let's give it a whirl...

@ablaom
Copy link
Member

ablaom commented Jan 28, 2024

The dev -> master PR will also run complete integration tests, including BetaML models (minus the clusterer in sylvaticus/BetaML.jl#64 we can put back later).

@ablaom ablaom merged commit 4b72780 into JuliaAI:dev Jan 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants