Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that we don't explicitly check user roles #135

Closed
Mehonoshin opened this issue May 21, 2018 · 1 comment
Closed

Ensure that we don't explicitly check user roles #135

Mehonoshin opened this issue May 21, 2018 · 1 comment
Assignees
@reabiliti
Labels
refactoring Does not output any noticeable changes for user
Milestone
Phase 2

Comments

@Mehonoshin
Copy link
Member

Instead, we should rely on policies for this purpose.
It'll allow us easier add new roles in the future.
@Mehonoshin Mehonoshin added the refactoring Does not output any noticeable changes for user label May 21, 2018
@Mehonoshin Mehonoshin added this to the Phase 2 milestone Jun 17, 2018
@Mehonoshin
Copy link
Member Author

We can just grep for has_role? to find places where do we use it

@reabiliti reabiliti self-assigned this Jun 19, 2018
reabiliti added a commit that referenced this issue Jun 19, 2018
@reabiliti
(#135) replace has_role? of policy
d4bee95
@reabiliti reabiliti mentioned this issue Jun 19, 2018
Merged
4 tasks
Mehonoshin added a commit that referenced this issue Jun 20, 2018
@Mehonoshin
Merge pull request #229 from howtohireme/135-check-user-role-only-policy
4f575da 
(#135) replace has_role? of policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reabiliti reabiliti

Labels
refactoring Does not output any noticeable changes for user
Projects
None yet
Milestone
Phase 2
Development

No branches or pull requests
2 participants
@Mehonoshin @reabiliti