Password sign in refactoring #218

Mehonoshin · 2018-06-15T19:44:34Z

Issue #179

Description

Adds the ability of password authentication/registration in Ideas namespace.
Also introduces form objects for users profile registration.

Testing steps

Visit [idea.lvh.me:3000/sessions/new]
Visit [idea.lvh.me:3000/registrations/new]
Test how profile step in sign in wizard works
Test user profile editing in dashboard
Test how the staff can edit user

Features PR URL

PR #8

Checklist

Make sure that all steps a checked before the merge

RSpec tests are passing on CI
Cucumber features are passing localy
bin/cop -a does not return any warnings
Tested manually

houndci-bot · 2018-06-15T19:44:46Z

spec/controllers/web/sign_outs_controller_spec.rb

@@ -0,0 +1,20 @@
+require 'rails_helper'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-06-15T19:44:46Z

app/controllers/web/sign_outs_controller.rb

@@ -0,0 +1,15 @@
+module Web


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

codeclimate · 2018-06-15T19:52:29Z

Code Climate has analyzed commit 03f1e58 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1
Style	1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 99.1% (0.0% change).

View more on Code Climate.

houndci-bot · 2018-06-16T08:49:39Z

app/views/layouts/idea.html.haml

+          %h3.masthead-brand= t('landing.brand')
+          %nav.nav.nav-masthead.justify-content-center
+            = nav_link t('landing.navigation.home'), root_landing_url, subdomain: 'www', id: 'home'
+            = link_to t('landing.navigation.dashboard'), dashboard_root_url, class: 'nav-link' if policy(:dashboard).allowed?


Line is too long. [125/120]

houndci-bot · 2018-06-16T08:49:39Z

app/views/layouts/idea.html.haml

+
+      %main.inner.cover{:role => "main"}
+        - if flash.alert
+          .alert.alert-danger{role: 'alert'}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2018-06-16T08:49:39Z

app/views/layouts/idea.html.haml

+            = link_to t('landing.navigation.dashboard'), dashboard_root_url, class: 'nav-link' if policy(:dashboard).allowed?
+            = link_to t('landing.navigation.logout'), logout_url, method: :delete, class: 'nav-link' if current_user
+
+      %main.inner.cover{:role => "main"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2018-06-16T08:49:39Z

app/operations/ops/author/sign_up.rb

@@ -0,0 +1,17 @@
+module Ops
+  module Author
+    class SignUp < BaseOperation


Style/Documentation: Missing top-level class documentation comment.

houndci-bot · 2018-06-16T08:49:40Z

app/operations/ops/author/sign_up.rb

@@ -0,0 +1,17 @@
+module Ops


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-06-16T08:49:40Z

app/forms/base_form.rb

@@ -0,0 +1,2 @@
+class BaseForm < Reform::Form


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-06-16T08:49:40Z

app/forms/author/registration.rb

@@ -0,0 +1,19 @@
+module Author
+  class Registration < BaseForm


Style/Documentation: Missing top-level class documentation comment.

houndci-bot · 2018-06-16T08:49:40Z

app/forms/author/registration.rb

@@ -0,0 +1,19 @@
+module Author


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-06-16T08:49:40Z

app/controllers/web/idea/registrations_controller.rb

+
+      def author_params
+        params.require(:user)
+          .permit(:email, :first_name, :last_name, :location, :timezone, :password)


Layout/MultilineMethodCallIndentation: Align .permit with .require on line 25.

houndci-bot · 2018-06-16T20:05:38Z

app/controllers/web/idea/registrations_controller.rb

+
+      def author_params
+        params.require(:user)
+          .permit(:email, :first_name, :last_name, :location, :timezone, :password)


Layout/MultilineMethodCallIndentation: Align .permit with .require on line 24.

houndci-bot · 2018-06-16T20:05:38Z

spec/controllers/web/idea/registrations_controller_spec.rb

+      end
+
+      it 'does not create new user' do
+        expect { post :create, params: params }


Lint/AmbiguousBlockAssociation: Parenthesize the param change { User.count } to make sure that the block will be associated with the change method call.

houndci-bot · 2018-06-16T20:05:38Z

spec/controllers/web/idea/registrations_controller_spec.rb

@@ -0,0 +1,102 @@
+require 'rails_helper'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-06-16T20:05:39Z

app/controllers/web/idea/registrations_controller.rb

+
+      def author_params
+        params.require(:user)
+          .permit(:email, :first_name, :last_name, :location, :timezone, :password)


Layout/MultilineMethodCallIndentation: Align .permit with .require on line 24.

houndci-bot · 2018-06-16T20:05:39Z

spec/controllers/web/idea/registrations_controller_spec.rb

+      end
+
+      it 'does not create new user' do
+        expect { post :create, params: params }


Lint/AmbiguousBlockAssociation: Parenthesize the param change { User.count } to make sure that the block will be associated with the change method call.

houndci-bot · 2018-06-16T20:05:39Z

spec/controllers/web/idea/registrations_controller_spec.rb

@@ -0,0 +1,102 @@
+require 'rails_helper'


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

Password sign in refactoring

03f1e58

Mehonoshin added the WIP label Jun 15, 2018

Mehonoshin self-assigned this Jun 15, 2018

houndci-bot reviewed Jun 15, 2018

View reviewed changes

WIP author registration

1197771

houndci-bot reviewed Jun 16, 2018

View reviewed changes

Registrations controller specs

c17a018

houndci-bot reviewed Jun 16, 2018

View reviewed changes

Mehonoshin added 7 commits June 16, 2018 23:31

Specs for SignUp registration

96c5f05

Fix rubocop offences

199f171

WIP profile form validation

5bd5f18

Add form object for CompleteUser operation

f87ea6e

Fix specs for author registration

010de17

User profile adjustments

ac8f1d5

Satisfy rubocop

39c8792

Mehonoshin removed the WIP label Jun 21, 2018

Mehonoshin merged commit 3a2abfb into master Jun 21, 2018

Mehonoshin deleted the email-password-auth branch June 21, 2018 18:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Password sign in refactoring #218

Password sign in refactoring #218

Mehonoshin commented Jun 15, 2018 •

edited

Loading

houndci-bot Jun 15, 2018

houndci-bot Jun 15, 2018

codeclimate bot commented Jun 15, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

houndci-bot Jun 16, 2018

Password sign in refactoring #218

Password sign in refactoring #218

Conversation

Mehonoshin commented Jun 15, 2018 • edited Loading

Description

Testing steps

Features PR URL

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codeclimate bot commented Jun 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mehonoshin commented Jun 15, 2018 •

edited

Loading