Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaces - expired namespaces visible without "Show expired namespaces" checkbox checked #873

Closed
cryptoBeliever opened this issue Jan 5, 2021 · 7 comments · Fixed by #1458
Assignees
Labels
P3 Issue Minor defect in aesthetics

Comments

@cryptoBeliever
Copy link
Contributor

On namespaces list by default expired namespaces are presented.

image

Expected result: Expired namespace hidden by default and visible only if we check "Show expired namespaces"

@cryptoBeliever cryptoBeliever added bug P3 Issue Minor defect in aesthetics labels Jan 5, 2021
@Pow1404 Pow1404 added this to Issue Backlog in Symbol Desktop Wallet Jan 8, 2021
@Pow1404 Pow1404 removed the bug label Feb 11, 2021
@boldchains boldchains assigned boldchains and unassigned boldchains Mar 19, 2021
@Peersyst Peersyst moved this from Issue Backlog to In sprint in Symbol Desktop Wallet Apr 14, 2021
@bassemmagdy bassemmagdy self-assigned this Apr 20, 2021
bassemmagdy added a commit that referenced this issue Apr 23, 2021
@bassemmagdy bassemmagdy linked a pull request Apr 23, 2021 that will close this issue
@bassemmagdy bassemmagdy moved this from In sprint to Feature ready for testing in Symbol Desktop Wallet Apr 23, 2021
@postoronnii
Copy link

@bassemmagdy I still can reproduce it
image

@bassemmagdy
Copy link
Contributor

@NikolaiB Recheck #1458

bassemmagdy added a commit that referenced this issue Jun 14, 2021
* fix #873

* update namespaceTableService

* fix expiry checkbox
@surekabpm surekabpm moved this from Feature ready for testing to Ready for integration testing in Symbol Desktop Wallet Jun 22, 2021
@cryptoBeliever
Copy link
Contributor Author

@NikolaiB please retest (I don't own expired namespace on testnet)

@cryptoBeliever
Copy link
Contributor Author

@NikolaiB could you check?

@postoronnii
Copy link

@bassemmagdy there are 15 hours left till expiration namespace but it has expired state already
image

@postoronnii postoronnii reopened this Jul 15, 2021
Symbol Desktop Wallet automation moved this from Quality Assurance to In Progress Jul 15, 2021
@cryptoBeliever cryptoBeliever added this to Product Backlog in Wallets Jul 19, 2021
@cryptoBeliever cryptoBeliever moved this from Product Backlog to In progress in Wallets Jul 19, 2021
@bassemmagdy
Copy link
Contributor

@NikolaiB since the issue is not testable on our public nodes as the minimum namespace is large enough. I've started a local node to check and it looks like no issues here is a video also I created a new branch with custom validation for testing purposes.

Here are the steps to verify:

  1. install symbol-bootstrap globally and run a local node by default minimum namespace duration is 1 minute. make sure localhost:3000/node/health is up and running
  2. connect the node to the wallet.
  3. head to target/nemesis/server-config/block-properties-file.properties file on your machine under [distribution>cat: currency] section in that file you should find addresses containing funds on your local node, and for the corresponding private keys they are in the target/addresses.yml file, import any of them.
  4. import any of the private keys into wallet while connected to the local node you should be able to test it.

@bassemmagdy bassemmagdy moved this from In Progress to Quality Assurance in Symbol Desktop Wallet Aug 4, 2021
@postoronnii
Copy link

@bassemmagdy @cryptoBeliever fixed

Wallets automation moved this from In progress to Done Aug 10, 2021
@cryptoBeliever cryptoBeliever moved this from Quality Assurance to Done in Symbol Desktop Wallet Aug 10, 2021
@surekabpm surekabpm moved this from Done to Pending Release in Symbol Desktop Wallet Aug 24, 2021
@surekabpm surekabpm moved this from Done to Pending Release in Wallets Sep 2, 2021
@cryptoBeliever cryptoBeliever moved this from Pending Release to Done in Symbol Desktop Wallet Sep 8, 2021
@coiki coiki moved this from Pending Release to Done in Wallets Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Issue Minor defect in aesthetics
Projects
Development

Successfully merging a pull request may close this issue.

5 participants