Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprint 1 fixes #1542

Merged
merged 30 commits into from
Jun 18, 2021
Merged

Sprint 1 fixes #1542

merged 30 commits into from
Jun 18, 2021

Conversation

bassemmagdy
Copy link
Contributor

@bassemmagdy bassemmagdy commented Jun 17, 2021 •
edited

Fixes:

myxmaster and others added 30 commits May 31, 2021 22:28
@myxmaster
fix scrolling on aggregate tx page (#1352)
10a7d1f
@AnthonyLaw
fix: balance aligment UI issue. (#1521)
3e81ade
@bassemmagdy @AnthonyLaw
checks if bonded is signed in transactions history list (#1522)
7e43fe0 
* checks if bonded is signed in transactions history list #1488

* Update src/language/zh-CN.json

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* refactor needsCosignature check to async

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>
@bassemmagdy
bugfix/Scanning a qr with no mosaics breaks the wallet (#1518)
3f1c586 
* fix Scanning a QR Code for a Transfer Transaction without Mosaics breaks the Wallet #1503

* fix fees list consistency
@bassemmagdy
fix mosaic amount sometimes not shown while importing mnemonic (#1517)
b2f2d9e 
* fix #1514

* add loader on fetching accounts balances

* remove setTimeout
@bassemmagdy @OlegLialin
enhance profile creation phrasing (#1512)
ef5341e 
* Rephrased profile creation

* fix #930

Co-authored-by: olegliallin <olegliallin@gmail.com>
@bassemmagdy
fix wrong expired message for mosaics with 0 balance #1468 (#1511)
bb440a8
@bassemmagdy
fix setting popup styles (#1509)
9a27562 
* fix setting popup styles #1448

* fix redundant scrollbar

* fix fees not always displayed

* fix scrollbar issue

* update settings modal
@bassemmagdy
Gh1431 harvesting fix (#1528)
ac6e481 
* fix #1431 #1332

* fix harvesting showing wrong status on fresh accounts
@bassemmagdy
fix #1264 (#1480)
3920d78
@bassemmagdy
fix error message while creating new profile on ledger (#1508)
0e4458d 
* fix error message while creating new profile on ledger #1483

* remove logs
@bassemmagdy
fix icons inconsistency (#1507)
d7c48ea 
* fix iconsconsistency #1446

* update multisigForm add button styles

* fix button style

* fix #1445
@bassemmagdy
fix #1472 (#1506)
4b8c925
@bassemmagdy
Fix harvesting tabs alignment (#1500)
e146d95 
* sort fees selector options #1430

* fix tab alignments in harvesting page #1441

* fixes #1491

* update fees selector
@bassemmagdy
fix amount field bug while importing transaction from a qr-code (#1485)
86dc000
@bassemmagdy
fix #1459 (#1460)
943aa2e 
* fix date not showing properly for aggregate transactions #1459

* fix transfer transaction date diplay

* update hashlock date representation
@segfaultxavi
Fix log in/log out spelling (#1450)
b1f8180 
"Log in/out" is a verb, whereas "login/logout" are nouns.
@bassemmagdy @segfaultxavi
fix #1076 #1416 (#1449)
11ec754 
* fix #1076 #1416

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update settings modal to select networkTab when opened from node selector

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
@bassemmagdy
fix #873 (#1458)
eaf4757 
* fix #873

* update namespaceTableService

* fix expiry checkbox
@bassemmagdy @segfaultxavi
fix validation for namespace name #1376 (#1452)
5733bce 
* fix validation for namespace name #1376

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* add comment to update regex when rest is fixed

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
@AnthonyLaw
fix: namespace expired logic error. (#1525)
7463a7f
@bassemmagdy
display delegate harvesting message properly (#1513)
f76d853
@bassemmagdy
fix connected nodes doesn't show up in node selector harvesting (#1502)
d16038c 
* fix connected nodes doesn't show up in node selector harvesting #1106

* update peerNodes
@bassemmagdy
fix un-signed transactions disappear after signing another partial #1487
dd292c2 
 (#1499)
@bassemmagdy
fix the unablity to add node when all default nodes offline #1236 (#1489
3243a6b 
)
@bassemmagdy
fix #1432 (#1439)
592c32b 
* fix Harvesting when importing harvesting private key from node operator #1432

* fix #1432

* Update NetworkNodeSelectorTs.ts
@bassemmagdy
fix translation in login page
71973bd
@bassemmagdy @segfaultxavi
Gh1090 improve transaction previews (#1540)
12a0d3d 
* improve transactiondashboard preview #1190

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update mosaic list tooltip

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
@bassemmagdy
Revert "Gh1090 improve transaction previews (#1540)" (#1543)
0b57942 
This reverts commit 12a0d3d.
@bassemmagdy
fix #1432
a38e513
@bassemmagdy bassemmagdy merged commit 38a7591 into integration Jun 18, 2021
@bassemmagdy bassemmagdy deleted the sprint-fixes branch June 18, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdriaCarrera AdriaCarrera AdriaCarrera approved these changes

@rg911 rg911 Awaiting requested review from rg911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bassemmagdy @AdriaCarrera @myxmaster @AnthonyLaw @segfaultxavi