multi-level msig required cosignatures, txs issues fixed, signer selector&filter tree view, misc. bugfixes #1698
Conversation
yilmazbahadir
force-pushed
the
fix/gh-1687-refactor-multilevel-msig-required-cosignatures
branch
from
635b073
to
bea6972
Compare
…fix: partial txs cannot be shown consistently issue fixed
yilmazbahadir
force-pushed
the
fix/gh-1687-refactor-multilevel-msig-required-cosignatures
branch
from
bea6972
to
a427920
Compare
|
@yilmazbahadir all looks good for me 👍 |
| @@ -736,7 +736,7 @@ export class FormTransferTransactionTs extends FormTransactionBase { | |||
| this.networkType, | |||
| this.networkConfiguration, | |||
| this.transactionFees, | |||
| this.currentSignerMultisigInfo ? this.currentSignerMultisigInfo.minApproval : this.selectedSigner.requiredCosignatures, | |||
| this.currentSignerMultisigInfo ? this.currentSignerMultisigInfo.minApproval : this.selectedSigner.requiredCosigApproval, | |||
There was a problem hiding this comment.
Why not using the selectedSigner.requiredCosigApproval directly for both cases same as FormMetadataCreationTs.ts?
There was a problem hiding this comment.
Thanks, just refactored this line.
After the signer changes in place, I think most of the places using currentSignerMultisigInfo can be refactored to use the signer instead. I just didn't want to make this PR too big and introduce too much change. But I think this line could be change, tested locally seems fine.
There was a problem hiding this comment.
I agree, We should do the other places in a separate PR.
…ignerMultisigInfo
|
Kudos, SonarCloud Quality Gate passed!
|
yilmazbahadir
deleted the
fix/gh-1687-refactor-multilevel-msig-required-cosignatures
branch
fixes #1687 , #1688, #1697
Changes:
Signerclass holds references to its parents as a tree (parentSigners), allSigner'srequiredCosigApprovalandrequiredCosigRemovals are pre-calculated while constructing the tree. This info is used to decide on creating AGGREGATE_COMPLETE when there is only 1 cosigner needed to approve(minApproval === 1).SignerSelector and SignerFilter dropdowns show signers as grouped and in a tree structure (starting from the leave(current account) going down to the root signer (supporting multiple, multi-level multisig structures)
SignerSelector and SignerFilter components refactored to use the same base and became =>
SignerSelector,SignerListFilter=> extending/usingSignerBaseFilterSeveral bugs noticed during the testing are fixed.