Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk/python] improved vectors generation #118

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

gimre-xymcity
Copy link
Member

@gimre-xymcity gimre-xymcity commented Feb 15, 2022

What's the issue?

There's a lot of repetitions and lot of senseless cases (mostly) in symbol tx test vectors

How have you changed the behavior?

  • converted "generate" functions to "recipes
  • removed duplicates
  • removed senseless cases
  • introduced new cases, mostly oriented around flags covering

How was this change tested?

sdk/python/testvectors/README.md Show resolved Hide resolved
sdk/python/testvectors/__main__.py Outdated Show resolved Hide resolved
sdk/python/testvectors/__main__.py Show resolved Hide resolved
sdk/python/testvectors/__main__.py Outdated Show resolved Hide resolved
sdk/python/testvectors/__main__.py Outdated Show resolved Hide resolved
sdk/python/testvectors/__main__.py Outdated Show resolved Hide resolved
sdk/python/testvectors/__main__.py Outdated Show resolved Hide resolved
sdk/python/testvectors/__main__.py Outdated Show resolved Hide resolved
sdk/python/testvectors/__main__.py Outdated Show resolved Hide resolved
@Jaguar0625
Copy link
Contributor

@lgtm-com
Copy link

lgtm-com bot commented Feb 16, 2022

This pull request introduces 3 alerts when merging 6c86df7 into ae6375e - view on LGTM.com

new alerts:

  • 3 for Unused import

@gimre-xymcity gimre-xymcity force-pushed the sdk/python/vectors-2.0 branch 2 times, most recently from 5065789 to 70afb80 Compare February 16, 2022 15:34
sdk/python/symbolchain/facade/SymbolFacade.py Show resolved Hide resolved
sdk/python/symbolchain/symbol/TransactionFactory.py Outdated Show resolved Hide resolved
sdk/python/tests/facade/test_SymbolFacade.py Outdated Show resolved Hide resolved
sdk/python/tests/facade/test_SymbolFacade.py Show resolved Hide resolved
sdk/python/testvectors/symbol/blocks.py Outdated Show resolved Hide resolved
tests/vectors/symbol/transactions/transactions.yaml Outdated Show resolved Hide resolved
tests/vectors/symbol/transactions/transactions.yaml Outdated Show resolved Hide resolved
@gimre-xymcity gimre-xymcity merged commit e0af09f into feature/test-vectors-regen Feb 16, 2022
@gimre-xymcity gimre-xymcity deleted the sdk/python/vectors-2.0 branch February 16, 2022 21:40
@gimre-xymcity
Copy link
Member Author

merged into feature branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants