Equal degree #1026
Merged
Equal degree #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int mod_val = mp_get_si(modulo_); | ||
| std::vector<integer_class> v(n_val + 1); | ||
| for (int i = 0; i < n; ++i) { | ||
| v[i] = integer_class(std::rand() % mod_val); |
There was a problem hiding this comment.
There are random number generators in GMP. We should use one of those if we are dealing with big numbers.
|
@isuruf left some commens. Overall it looks good. |
nishnik
force-pushed
the
equal_degree
branch
3 times, most recently
from
d389273
to
e528014
Compare
| std::vector<GaloisFieldDict> b; | ||
| if (modulo_ != 2_z) | ||
| b = this->gf_frobenius_monomial_base(); | ||
| size_t seed = 123456; |
There was a problem hiding this comment.
Use std::rand() to generate the seed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equal Degree Zassenhaus's algorithm