Check for flint-arb #1749
Merged
Check for flint-arb #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sageb0t
pushed a commit
to sagemath/sagetrac-mirror
that referenced
this pull request
Mar 20, 2021
lkeegan
approved these changes
Mar 21, 2021
There was a problem hiding this comment.
@isuruf re the codecov upload issue, it seems related to codecov using the github actions job id to authenticate the upload, as they also check that the job is not stale, and since both jobs that upload have the same name it could be that they end up checking the wrong one when the slower job tries to upload?..
hopefully using a token for the upload instead will work better: #1752
|
This works well on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mkoeppe