Allow to retry a model when it errors #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruiAzevedo19
force-pushed
the
123-model-retry
branch
3 times, most recently
from
b5129de
to
3decf21
Compare
ruiAzevedo19
force-pushed
the
123-model-retry
branch
from
3decf21
to
280e54e
Compare
bauersimon
requested changes
May 17, 2024
ruiAzevedo19
force-pushed
the
123-model-retry
branch
from
280e54e
to
4a67cb3
Compare
zimmski
reviewed
May 18, 2024
zimmski
reviewed
May 18, 2024
zimmski
reviewed
May 18, 2024
| ) | ||
| }, | ||
| After: func(t *testing.T, logger *log.Logger, resultPath string) { | ||
| delete(provider.Providers, "testing-provider") |
There was a problem hiding this comment.
This is a source of problems, when we register a provider temporarily, we can run into concurrency problems. Better to refactor the code, make the provider a parameter and mock that parameter instead. Easier to type. Easier to understand. Less code. Cleaner.
zimmski
reviewed
May 18, 2024
| Name: "Single try fails", | ||
|
|
||
| Before: func(t *testing.T, logger *log.Logger, resultPath string) { | ||
| queryMock.On("Query", mock.Anything, "testing-provider/testing-model", mock.Anything).Return("", errors.New("empty response from model")) |
There was a problem hiding this comment.
Do not copy errors, create a variable.
There was a problem hiding this comment.
If you copy, don't. Create an API for it.
zimmski
reviewed
May 18, 2024
| @@ -124,3 +147,8 @@ func (m *Model) GenerateTestsForFile(logger *log.Logger, language language.Langu | |||
|
|
|||
| return assessment, nil | |||
| } | |||
|
|
|||
| // SetAttempts sets the number of attempts to perform when a model errors in the process of solving a task. | |||
There was a problem hiding this comment.
When we implement an interface, we always explicitly check that the interface is implemented it in the code. Even if it is just one method.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #123