Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up: Allow to retry a model when it errors #131

Closed
2 of 3 tasks
zimmski opened this issue May 18, 2024 · 0 comments · Fixed by #139
Closed
2 of 3 tasks

Follow-up: Allow to retry a model when it errors #131

zimmski opened this issue May 18, 2024 · 0 comments · Fixed by #139
Assignees
@ruiAzevedo19
Labels
enhancement New feature or request
Milestone
v0.5.0

Comments

@zimmski
Copy link
Member

zimmski commented May 18, 2024 •
edited by ruiAzevedo19
Loading

@ruiAzevedo19 please take care of this before moving to the next task.
@zimmski zimmski added the enhancement New feature or request label May 18, 2024
@zimmski zimmski added this to the v0.5.0 milestone May 18, 2024
zimmski added a commit that referenced this issue May 20, 2024
@zimmski
refactor, Move evaluation logic into evaluation package for isolation…
7b441a9 
… of concern

Part of #131
@zimmski zimmski mentioned this issue May 20, 2024
Merged
zimmski added a commit that referenced this issue May 20, 2024
@zimmski
refactor, Move evaluation logic into evaluation package for isolation…
c6f4113 
… of concern

Part of #131
zimmski added a commit that referenced this issue May 20, 2024
@zimmski
refactor, Move evaluation logic into evaluation package for isolation…
46e876c 
… of concern

Part of #131
ruiAzevedo19 added a commit that referenced this issue May 20, 2024
@ruiAzevedo19
Remove the need to change the provider registery in tests
890122c 
Part of #131
@ruiAzevedo19 ruiAzevedo19 mentioned this issue May 20, 2024
Merged
ruiAzevedo19 added a commit that referenced this issue May 20, 2024
@ruiAzevedo19
Remove the need to change the provider registery in tests
bc2a9d2 
Part of #131
zimmski added a commit that referenced this issue May 20, 2024
@zimmski
Remove the need to change the provider registery in tests to make tes…
e65019a 
…t code concurrency safe

Part of #131
zimmski added a commit that referenced this issue May 20, 2024
@zimmski
fix, Set query attempts in common evaluation code, because it needs t…
56bee0f 
…o be applied commonly

Part of #131
zimmski added a commit that referenced this issue May 20, 2024
@zimmski
fix, Set query attempts in common evaluation code, because it needs t…
9f7a673 
…o be applied commonly

Part of #131
zimmski added a commit that referenced this issue May 20, 2024
@zimmski
fix, Set query attempts in common evaluation code, because it needs t…
eac1e76 
…o be applied commonly

Part of #131
zimmski added a commit that referenced this issue May 20, 2024
@zimmski
Remove the need to change the provider registery in tests to make tes…
e27f2e2 
…t code concurrency safe

Part of #131
zimmski added a commit that referenced this issue May 20, 2024
@zimmski
fix, Set query attempts in common evaluation code, because it needs t…
7bcd387 
…o be applied commonly

Part of #131
ruiAzevedo19 added a commit that referenced this issue May 21, 2024
@ruiAzevedo19
refactor, Move the error used in the evaluation tests to a variable, …
4c50f29 
…to avoid copying it the test suites

Part of #131
@ruiAzevedo19 ruiAzevedo19 mentioned this issue May 21, 2024
Merged
ruiAzevedo19 added a commit that referenced this issue May 21, 2024
@ruiAzevedo19
Explicitly check the interface that is setting the query attempts
139171f 
Closes #131
@ruiAzevedo19 ruiAzevedo19 mentioned this issue May 21, 2024
Merged
ruiAzevedo19 added a commit that referenced this issue May 21, 2024
@ruiAzevedo19
Explicitly check the interface that is setting the query attempts, to…
1dde40b 
… ensure the model implements all its methods

Closes #131
Munsio pushed a commit that referenced this issue Jun 3, 2024
@zimmski @Munsio
refactor, Move evaluation logic into evaluation package for isolation…
635749a 
… of concern

Part of #131
Munsio pushed a commit that referenced this issue Jun 3, 2024
@zimmski @Munsio
Remove the need to change the provider registery in tests to make tes…
7f48474 
…t code concurrency safe

Part of #131
Munsio pushed a commit that referenced this issue Jun 3, 2024
@zimmski @Munsio
fix, Set query attempts in common evaluation code, because it needs t…
c194f5f 
…o be applied commonly

Part of #131
Munsio pushed a commit that referenced this issue Jun 3, 2024
@ruiAzevedo19 @Munsio
refactor, Move the error used in the evaluation tests to a variable, …
6ffd259 
…to avoid copying it the test suites

Part of #131
Munsio pushed a commit that referenced this issue Jun 3, 2024
@ruiAzevedo19 @Munsio
Explicitly check the interface that is setting the query attempts, to…
7a5238e 
… ensure the model implements all its methods

Closes #131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruiAzevedo19 ruiAzevedo19

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
2 participants
@zimmski @ruiAzevedo19