Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check the interface that is setting the query attempts, to ensure the model implements all its methods #139

Merged
merged 1 commit into from
May 21, 2024

Conversation

ruiAzevedo19
Copy link
Collaborator

Closes #131

@ruiAzevedo19 ruiAzevedo19 added the enhancement New feature or request label May 21, 2024
@ruiAzevedo19 ruiAzevedo19 added this to the v0.5.0 milestone May 21, 2024
@ruiAzevedo19 ruiAzevedo19 self-assigned this May 21, 2024
@ruiAzevedo19 ruiAzevedo19 marked this pull request as draft May 21, 2024 11:21
… ensure the model implements all its methods

Closes #131
@ruiAzevedo19 ruiAzevedo19 marked this pull request as ready for review May 21, 2024 12:42
@ruiAzevedo19 ruiAzevedo19 requested a review from Munsio May 21, 2024 12:43
@ruiAzevedo19 ruiAzevedo19 changed the title Explicitly check the interface that is setting the query attempts Explicitly check the interface that is setting the query attempts, to ensure the model implements all its methods May 21, 2024
@Munsio Munsio merged commit e524291 into main May 21, 2024
3 checks passed
@Munsio Munsio deleted the 131-check-attempts-interface branch May 21, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up: Allow to retry a model when it errors
2 participants