Improve admin UX

[wouterj]

Menus was, and still is, one of less easy to use admin interface. This PR tries to fix it a bit.

I changed 2 main things;

• Menu admin only shows name + label + menu items, there is no reason to show linking stuff and such in here
• MenuNode admin does no longer show a "route" and "uri" field, but it shows one "link" field instead. The linkType select input will determine what the value of "link" is (if it's a route or uri)

[dbu]

yes :-)

[dbu]

cool, makes a lot of sense!

the only bit i am unsure is the commented out line for the route. are there other reasons why you have "WIP" in the description?

restarted the build to see if it works now - had a composer failure before.

[wouterj]

are there other reasons why you have "WIP" in the description?

I'm planning to do more UX fixes for the menu admin. However, those doesn't need to be all in the same PR (I know you like quick merging, so +1 to merge if we all agree with the changes and travis is happy too).

[wouterj]

Fixed the last commit. @dbu do you like this direction I took with simplifying uri/route?

The build errors are because of a BC break in Sonata 2.4 (in 2.4, they typehint against FormBuilderInterface while they typehint against FormBuilder in 2.3). We either do not support 2.4 and use FormBuilder or we have to come up with another plan to avoid using this method.

[dbu]

this seems leftover debug code

[dbu]

regarding sonata: i think we should push as much as we can to standard form types and do as little sonata as possible.
afaik we said the next version of the phpcr admin will require base sonata 2.4 so i would opt for the new signature

[wouterj]

So, we can now start implementing Sonata 2.4 in the CMF? I thought we decided not to go for 2.4 requirements a couple of weeks back. However, going with the 2.4 requirement means we can merge a lot of my PRs about Admin UX improvements.

[dbu]

https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/blob/master/composer.json#L21
https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/blob/master/composer.json#L40

so the current master of the phpcr admin is for 2.0, and will require sonata admin 2.4. i am hesitating to merge the other PRs until we can be reasonable sure that the phpcr admin 2.0 is ready in time for the release of new versions. with what i just merged, we seem one big step closer to that however. i will try to have a look at this all this week and give my opinion.

[lsmith77]

1) Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension\MenuNodeReferrersExtensionTest::testEdit
Exception: "
                Child "link" does not exist.
            "
Failed asserting that 500 matches expected 200.

[wouterj]

Should be fixed now.

[dbu]

thanks!