Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Remove deprecations #222

Merged
merged 4 commits into from
May 25, 2015
Merged

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented May 25, 2015

No description provided.

@lsmith77
Copy link
Member

The "request" service is deprecated and will be removed in 3.0. Add a typehint for Symfony\Component\HttpFoundation\Request to your controller parameters to retrieve the request instead: 52x
    13x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    10x in MenuNodeAdminTest::testDelete from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    10x in MenuAdminTest::testMenuDelete from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    8x in MenuAdminTest::testMenuCreate from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    3x in MenuNodeAdminTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    3x in MenuAdminTest::testMenuShow from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    3x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuList from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
The "app.security" variable is deprecated since version 2.6 and will be removed in 3.0: 18x
    4x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    2x in MenuNodeAdminTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuNodeAdminTest::testDelete from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuDelete from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuShow from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuList from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuCreate from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
The "_method" requirement is deprecated since version 2.2 and will be removed in 3.0. Use the setMethods() method instead or the "methods" option in the route definition: 17x
    13x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    4x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
The FormTypeExtensionInterface::setDefaultOptions() method is deprecated since version 2.7 and will be removed in 3.0. Use configureOptions() instead. This method will be added to the FormTypeExtensionInterface with Symfony 3.0: 16x
    6x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    4x in MenuAdminTest::testMenuCreate from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuNodeAdminTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuList from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
The Symfony\Bundle\FrameworkBundle\Controller\Controller::getRequest method is deprecated since version 2.4 and will be removed in 3.0. The only reliable way to get the "Request" object is to inject it in the action method: 15x
    4x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    3x in MenuAdminTest::testMenuDelete from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    3x in MenuNodeAdminTest::testDelete from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    3x in MenuAdminTest::testMenuCreate from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    1x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    1x in MenuNodeAdminTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
The FormTypeInterface::setDefaultOptions() method is deprecated since version 2.7 and will be removed in 3.0. Use configureOptions() instead. This method will be added to the FormTypeInterface with Symfony 3.0: 15x
    6x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    4x in MenuAdminTest::testMenuCreate from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    3x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuNodeAdminTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
The Symfony\Component\EventDispatcher\Event::getName method is deprecated since version 2.4 and will be removed in 3.0. The event name can be received in the listener call instead: 14x
    4x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    2x in MenuAdminTest::testMenuCreate from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuNodeAdminTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuList from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    2x in MenuAdminTest::testMenuShow from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
The Symfony\Component\Validator\Validator\RecursiveValidator::getMetadataFactory method is deprecated in version 2.5 and will be removed in version 3.0. Use the Symfony\Component\Validator\Validator\ValidatorInterface::getMetadataFor or Symfony\Component\Validator\Validator\ValidatorInterface::hasMetadataFor method instead: 13x
    9x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
    2x in MenuAdminTest::testMenuCreate from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    1x in MenuNodeAdminTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    1x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
The "pattern" option in file "/home/travis/build/symfony-cmf/MenuBundle/vendor/sonata-project/admin-bundle/Resources/config/routing/sonata_admin.xml" is deprecated since version 2.2 and will be removed in 3.0. Use the "path" option in the route definition instead: 8x
    8x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
The Symfony\Component\Form\Extension\Csrf\CsrfProvider\CsrfTokenManagerAdapter::generateCsrfToken method is deprecated since version 2.4 and will be removed in version 3.0. Use the Symfony\Component\Security\Csrf\CsrfTokenManager class instead: 3x
    1x in MenuNodeAdminTest::testDelete from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    1x in MenuAdminTest::testMenuList from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    1x in MenuAdminTest::testMenuDelete from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
The Symfony\Component\Form\Extension\Csrf\CsrfProvider\CsrfTokenManagerAdapter::isCsrfTokenValid method is deprecated since version 2.4 and will be removed in version 3.0. Use the Symfony\Component\Security\Csrf\CsrfTokenManager class instead: 2x
    1x in MenuNodeAdminTest::testDelete from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    1x in MenuAdminTest::testMenuDelete from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
The Symfony\Component\Form\Extension\HttpFoundation\EventListener\BindRequestListener class is deprecated since version 2.3 and will be removed in 3.0. Pass the Request instance to the \Symfony\Component\Form\Form::handleRequest() method instead: 2x
    1x in MenuAdminTest::testMenuCreate from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    1x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
Passing a Symfony\Component\HttpFoundation\Request object to the Symfony\Component\Form\Form::bind and Symfony\Component\Form\Form::submit methods is deprecated since 2.3 and will be removed in 3.0. Use the Symfony\Component\Form\Form::handleRequest method instead. If you want to test whether the form was submitted separately, you can use the Symfony\Component\Form\Form::isSubmitted method: 2x
    1x in MenuAdminTest::testMenuCreate from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
    1x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
The Symfony\Component\Security\Core\SecurityContextInterface interface is deprecated since version 2.6 and will be removed in 3.0: 1x
    1x in MenuContentVoterTest::providePublishWorkflowChecker from Symfony\Cmf\Bundle\MenuBundle\Tests\Unit\PublishWorkflow\Voter
The Symfony\Component\OptionsResolver\OptionsResolver::setOptional method is deprecated since version 2.6 and will be removed in 3.0. Use the setDefined() method instead: 1x
    1x in MenuAdminTest::testMenuEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin
Constants PRE_BIND, BIND and POST_BIND in class Symfony\Component\Form\FormEvents are deprecated since version 2.3 and will be removed in 3.0. Use PRE_SUBMIT, SUBMIT and POST_SUBMIT instead: 1x
    1x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
The Symfony\Component\Security\Core\SecurityContext class is deprecated since version 2.6 and will be removed in 3.0. Use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage or Symfony\Component\Security\Core\Authorization\AuthorizationChecker instead: 1x
    1x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension
The "pattern" option in file "/home/travis/build/symfony-cmf/MenuBundle/vendor/friendsofsymfony/jsrouting-bundle/Resources/config/routing/routing.xml" is deprecated since version 2.2 and will be removed in 3.0. Use the "path" option in the route definition instead: 1x
    1x in MenuNodeReferrersExtensionTest::testEdit from Symfony\Cmf\Bundle\MenuBundle\Tests\WebTest\Admin\Extension

@lsmith77 lsmith77 changed the title Remove deprecations [WIP] Remove deprecations May 25, 2015
@wouterj
Copy link
Member Author

wouterj commented May 25, 2015

@lsmith77 all these deprecations are coming from SonataAdminBundle 2.3 and most of them are fixed in 2.4. That's why I wanted to set the mode to weak. Seems like I made a typo or so

@wouterj wouterj changed the title [WIP] Remove deprecations Remove deprecations May 25, 2015
@@ -15,6 +15,7 @@ cache:

env:
- SYMFONY_VERSION=2.6.*
- SYMFONY_DEPRECATIONS_HELPER=weak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to still add a SYMFONY_VERSION

wouterj added a commit that referenced this pull request May 25, 2015
@wouterj wouterj merged commit 81d1b53 into symfony-cmf:master May 25, 2015
@wouterj wouterj removed the review label May 25, 2015
@wouterj wouterj deleted the remove_deprecations branch May 25, 2015 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants