This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
allow KeyValueContainer objects to be passed as key-value arrays #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, i will delete my PR :-), yours is better and recognized the the form option too. |
| ->add('extraHttp', 'burgov_key_value', array('required' => false, 'value_type' => 'text')) | ||
| ->add('extraProperties', 'burgov_key_value', array('required' => false, 'value_type' => 'text', 'use_container_object' => true)) | ||
| ->add('extraNames', 'burgov_key_value', array('required' => false, 'value_type' => 'text', 'use_container_object' => true)) | ||
| ->add('extraHttp', 'burgov_key_value', array('required' => false, 'value_type' => 'text', 'use_container_object' => true)) |
There was a problem hiding this comment.
Can you change to one parameter per line for the options array, please. getting longer now.
There was a problem hiding this comment.
updated
I decided to keep it D.R.Y. ;)
| @@ -79,19 +81,19 @@ public function setTitle($title); | |||
| public function getTitle(); | |||
|
|
|||
| /** | |||
| * @param array | |||
| * @param array|KeyValueContainer | |||
There was a problem hiding this comment.
is it OK like this, or should I remove the use statement and use FQDN's for all three methods?
There was a problem hiding this comment.
no, you did it the correct way :)
|
thx, I've updated the commit |
dbu
added a commit
that referenced
this pull request
May 2, 2014
allow KeyValueContainer objects to be passed as key-value arrays
|
thanks a lot for finding this solution! |
|
created a follow-up PR in #159 about the traversable topic - i understood it does not work with the form layer, but it could be useful elsewhere. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issues described in #255