This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
Fix randomly failing test #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** @var Response $response */ | ||
| $response = $this->controller->indexAction('xml', 'test'); | ||
|
|
||
| $this->assertEquals(new Response('some-xml-string'), $response->getContent()); | ||
| $this->assertEquals('some-xml-string', $response->getContent()); |
There was a problem hiding this comment.
this was the actual cause of the random test failures: We compared a Response object to $response->getContent(). That means that PHP/HHVM needed to convert the first argument to a string before comparing with getContent. Some versions of HHVM did not do this and threw an exception: Comparing an object with a string
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests randomly failed on HHVM. I have no idea why, but the tests was a bit... strange.
The controller passes
$templating->rendertonew Response(), which is perfect (asrender()returns a string).The tests however mocked the render method and returned a
Responseobject. This results in:new Response(new Response(...));. This is a bit strange and not compliant with the API docs of this method.It works, as Response typecasts the object to a string and
Response::__toStringreturns, besides lots of other stuff, also the response content. This however, did fail for HHVM sometimes.Besides that, this method actually made the test test something. Before, it just tested that the templating was used, but not if the correct templates are used in the render call.