integrate ckeditor

[kosssi]

#33 : Integrate ckeditor

        {% render controller("symfony_cmf_create.jsloader.controller:includeJSFilesAction", {
            'editor': 'ckeditor'
        }) %}

[dbu]

we discussed this at the symfony live hackday and i think this is the way to go until a really good js handling solution is found. the advantage over #42 is that we only maintain the version what is checked out in one single place.

this is also open to improvements by using the composer.json extra fields to configure the repository and version id to use, if somebody wants a non-default version of ckeditor in his project.

@kingcrunch what do you think about this solution?

[dbu]

@kosssi don't we need to include any css files for ckeditor as well?

[kosssi]

Sorry, but i amend my pull-request...

@dbu ckeditor don't have realy css, i think. It's style.js file.

[dbu]

the doc will explain that you can overwrite these configuration options in a javascript loaded afterwards. i think this is good enough so we don't want to expose any configuration options to symfony for this but have people change those variables (particularly the config.customConfig path to use a non-default config.js)

[kosssi]

yes it's better ;)

[kosssi]

Now, it's possible to configure ckeditor in composer.json :

"scripts": {
    "post-install-cmd": [
        ...
        "Symfony\\Cmf\\Bundle\\CreateBundle\\Composer\\ScriptHandler::downloadCkeditor",
        ...
    ],
    "post-update-cmd": [
        ...
        "Symfony\\Cmf\\Bundle\\CreateBundle\\Composer\\ScriptHandler::downloadCkeditor",
        ...
    ]
},
...
"extra": {
    ...
    "ckeditor-directory": "vendor/symfony-cmf/create-bundle/Symfony/Cmf/Bundle/CreateBundle/Resources/public/vendor/ckeditor",
    "ckeditor-repository": "https://github.com/ckeditor/ckeditor-releases.git",
    "ckeditor-commit": "bba29309f93a1ace1e2e3a3bd086025975abbad0"
}

And you juste should overload init-create-path.js for explain where is ckeditor.

[kingcrunch]

Currently on vacation, but looks like a quite nice solution I think :-)

[dbu]

i think the editorWidgets section should be done in userland, or not? we do not do it in the corresponding script of the hallo editor.

[kosssi]

ok

[dbu]

looks good. i added two comments, would be cool if we can solve those. then it should be good to merge.

can you please also do a PR against https://github.com/symfony-cmf/symfony-cmf-docs ?

[dbu]

i wonder if we should not have the same functionality for all editors and drop the "hallo" from this parameter. its the same problem regardless of the editor: have one that has no formattings enabled at all.

[kosssi]

ok

[kosssi]

All right for the documentation i do it Saturday April 20. before i don't have time.

[dbu]

thanks a lot!

maybe we need the lines about setEditorForProperty in the ckeditor js init script like we have them in the hallo editor. but best try this out when writing the documentation.