Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Switch to KnpMenuBundle 2.0 #202

Closed
benglass opened this issue Aug 11, 2014 · 10 comments
Closed

Switch to KnpMenuBundle 2.0 #202

benglass opened this issue Aug 11, 2014 · 10 comments

Comments

@benglass
Copy link
Member

2.0 has now been released https://github.com/KnpLabs/KnpMenu/tree/v2.0.1

Need to resolve
#82
#83
#3
#19

@lsmith77
Copy link
Member

oh sweet! it would be huge if we could adopt that for CmfMenuBundle .. I guess we would then also need to bump our version to 2.0

/cc @dbu

@lsmith77
Copy link
Member

#3 does not yet seem to be covered but will be in 2.1 -> KnpLabs/KnpMenu#161

@dbu
Copy link
Member

dbu commented Aug 12, 2014

i guess this could be too tight for our 1.2 release, unless somebody has a lot of time this week.

@dawehner proposed to have a look at the drupal 8 code which can handle breadcrumb independently from menu: https://twitter.com/da_wehner/status/498936596486701056 - so this could be another course of action: if the drupal code fits what we need, help david to build a clean standalone library out of that code.

@rande
Copy link

rande commented Aug 13, 2014

The 2.3 release to Sonata Admin Bundle will require KnpMenu 2.0. But as it is use for a specific menu, I guess we can rework the AdminBundle integration.

Let me know what you think

@lsmith77
Copy link
Member

It would be great to find a workaround.

@lsmith77
Copy link
Member

in the mean time .. I will start a 2.0 branch for CmfMenuBundle .. though I must admit I do not know the bundle in much detail .. but lets get it started ASAP.

@lsmith77
Copy link
Member

FYI @rande confirmed that SonataAdmin 2.3 will work with KnpMenu 1 and 2 after all

@rande
Copy link

rande commented Aug 19, 2014

It was wrong until sonata-project/SonataAdminBundle@cfad91f ;)

Now it is ok

@lsmith77
Copy link
Member

when are you going to tag a version with all of this?

@rande
Copy link

rande commented Aug 19, 2014

Missed this feature: tab/group layout. (Real life events sonata-project/SonataAdminBundle#1723 (comment))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants