Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Commit

Permalink
Github Templates - DevKit updates (#54)
Browse files Browse the repository at this point in the history
* DevKit updates

* Apply fixes from StyleCI (#55)

[ci skip] [skip ci]
  • Loading branch information
ElectricMaxxx committed May 16, 2018
1 parent 331fb91 commit aa0b1e2
Show file tree
Hide file tree
Showing 11 changed files with 81 additions and 0 deletions.
24 changes: 24 additions & 0 deletions .github/Bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
name: Bug Report
about: Report errors and problems

---

<!--
The Symfony Code of Conduct applies to all the activity on this repository.
See https://symfony.com/doc/current/contributing/code_of_conduct/index.html
-->

**Description**
<!-- A clear and concise description of the problem. -->

**How to reproduce**
<!-- Code and/or config needed to reproduce the problem. If it's a complex bug,
create a "bug reproducer" as explained in:
https://symfony.com/doc/current/contributing/code/reproducer.html -->

**Possible Solution**
<!--- Optional: only if you have suggestions on a fix/reason for the bug -->

**Additional context**
<!-- Optional: any other context about the problem: log messages, screenshots, etc. -->
10 changes: 10 additions & 0 deletions .github/Documentation_issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
name: Documentation Issue
about: Anything related to Symfony CMF Documentation

---

Symfony CMF Documentation has its own dedicated repository. Please open your
documentation-related issue at https://github.com/symfony-cmf/symfony-cmf-docs/issues

Thanks!
12 changes: 12 additions & 0 deletions .github/Feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
name: Feature Request
about: RFC and ideas for new features and improvements

---

**Description**
<!-- A clear and concise description of the new feature. -->

**Example**
<!-- A simple example of the new feature in action (include PHP code, YAML config, etc.)
If the new feature changes an existing feature, include a simple before/after comparison. -->
9 changes: 9 additions & 0 deletions .github/Security_issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
name: Security Issue
about: Report security-related errors

---

If you have found a security issue in Symfony, please send the details to
[David](mailto:david@liip.ch) or [Maximilian](mailto:maximilian.berghoff@gmx.de) and don't disclose it publicly until we can provide a
fix for it.
15 changes: 15 additions & 0 deletions .github/Support_question.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
name: Support Question
about: Questions about using Symfony CMF and its components

---

**Description**
<!-- A clear and concise description of the problem. -->

**How to reproduce (optional)**
<!-- Optional: Only if you have something to reproduce. Code and/or config needed to reproduce the problem. -->

**Possible Solution**
<!-- Optional: only if you have suggestions to solve it -->

4 changes: 4 additions & 0 deletions src/Registry/RepositoryRegistry.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,13 @@
class RepositoryRegistry implements RepositoryRegistryInterface
{
private $container;

private $serviceMap = [];

private $typeMap = [];

private $names = [];

private $defaultRepositoryName;

/**
Expand Down
2 changes: 2 additions & 0 deletions tests/Unit/DependencyInjection/CmfResourceExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
class CmfResourceExtensionTest extends \PHPUnit_Framework_TestCase
{
private $container;

private $extension;

private $repositoryFactory;

public function setUp()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
class DescriptionEnhancerPassTest extends \PHPUnit_Framework_TestCase
{
private $container;

private $factoryDefinition;

private $pass;

public function setUp()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
class DoctrinePhpcrOdmFactoryTest extends FactoryTestCase
{
private $session;

private $manager;

public function setUp()
Expand Down
1 change: 1 addition & 0 deletions tests/Unit/Registry/RepositoryRegistryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
class RepositoryRegistryTest extends \PHPUnit_Framework_TestCase
{
private $repository;

private $container;

public function setUp()
Expand Down
1 change: 1 addition & 0 deletions tests/Unit/Twig/DescriptionExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
class DescriptionExtensionTest extends \PHPUnit_Framework_TestCase
{
private $descriptionFactory;

private $twig;

public function setUp()
Expand Down

0 comments on commit aa0b1e2

Please sign in to comment.