minimum php version is 5.6 now #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dbu
commented
Jan 12, 2017
dbu
commented
- use short array notation
- use ::class pseudo-constant
- use createMock for phpunit
- simplify tests setup
pamil
approved these changes
Jan 12, 2017
dbu
force-pushed
the
php56
branch
2 times, most recently
from
3fd305e
to
9a5153e
Compare
|
@wouterj i now try to use the phpunit-bridge as well. but it looks like phpunit is not installed correctly - can you spot what i do wrong? |
dbu
force-pushed
the
php56
branch
2 times, most recently
from
2f13903
to
8627e65
Compare
fbourigault
reviewed
Jan 16, 2017
| @@ -15,15 +12,18 @@ cache: | |||
|
|
|||
| env: SYMFONY_VERSION=3.2.* | |||
|
|
|||
| global: | |||
There was a problem hiding this comment.
According to https://docs.travis-ci.com/user/environment-variables/#Defining-encrypted-variables-in-.travis.yml, the global key must be under the env key:
env:
global:
- SYMFONY_VERSION=3.2.*
- SYMFONY_PHPUNIT_DIR=.phpunit
- SYMFONY_PHPUNIT_REMOVE="symfony/yaml"
- SYMFONY_PHPUNIT_VERSION=5.6There was a problem hiding this comment.
now i feel stupid. thanks a lot for spotting this one! that fixes it
* use short array notation * use ::class pseudo-constant * use createMock for phpunit * simplify tests setup
|
ready to review and merge \o/ |
ElectricMaxxx
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.