This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
documentation for publish workflow #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,38 +23,212 @@ Configuration | |||
|
|
|||
| # app/config/config.yml | |||
| cmf_core: | |||
| document_manager_name: default | |||
| role: IS_AUTHENTICATED_ANONYMOUSLY # used by the publish workflow checker | |||
| document_manager_name: null # used for the twig functions to fetch documents | |||
There was a problem hiding this comment.
shouldn't this be manager_name?
There was a problem hiding this comment.
indeed it should, but its not. i'll do a separate PR once this change is merged.
There was a problem hiding this comment.
@rmsint: it would be consistent, yes. but unfortunately its like this in
the actual bundle atm. we should clean this up however. care to do a pr?
or open an issue so we don't forget?
There was a problem hiding this comment.
ok, I will do a PR on the CoreBundle to change it.
| </extension> | ||
| </extensions> | ||
| </sonata-admin> | ||
| </config> |
There was a problem hiding this comment.
@wouterj there was some guessing involved here. is this xml config more or less correct?
| <config> | ||
| <sonata-admin> | ||
| <!-- ... --> | ||
| <extensions> |
dbu
added a commit
that referenced
this pull request
Jul 14, 2013
documentation for publish workflow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documentation is for the not yet merged publish workflow refactoring.
This is going to conflict with #148 - i suggest i manually port the still relevant parts of #148 over to here once its merged.