This repository has been archived by the owner on Jan 1, 2023. It is now read-only.
Fix the Twig_Environment service in the container tests for Twig 2 #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
force-pushed
the
twig_2
branch
4 times, most recently
from
abd2c34
to
cfe110b
Compare
stof
added a commit
that referenced
this pull request
Aug 31, 2015
…r Twig 2 (stof) This PR was merged into the 2.6-dev branch. Discussion ---------- Fix the Twig_Environment service in the container tests for Twig 2 Commits ------- 820093c Refactor the static assets helper to use Symfony 3 APIs 275f6fe Fix tests for Symfony 3 by enabling the asset component a20ce0a Fix the Twig_Environment service in the container tests
| { | ||
| // Symfony <2.7 BC | ||
| if (!$assetsHelper instanceof AssetsHelper && !$assetsHelper instanceof CoreAssetsHelper) { | ||
| throw new \InvalidArgumentException('Argument 1 passed to '.__METHOD__.' must be an instance of Symfony\Bundle\FrameworkBundle\Templating\Helper\AssetsHelper or Symfony\Component\Templating\Helper\CoreAssetsHelper, instance of '.get_class($assetsHelper).' given'); | ||
| if (!$packages instanceof Packages && !$packages instanceof CoreAssetsHelper) { |
There was a problem hiding this comment.
What's the goal of this if statement ? Nothing is done in the body.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.