-
Notifications
You must be signed in to change notification settings - Fork 227
Conversation
Can you also update the XSD with the new config to support XML configs ? |
@@ -175,6 +175,21 @@ public function getConfigTreeBuilder() | |||
->end() | |||
->end() | |||
|
|||
// workers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if all this big tree can be wrapped each block into a method to refactor nicely the sections like elsewhere is done as this is getting too long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps better in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandermarechal 👍 Finish one task, than the next one.
@stof I have updated the XSD |
Add CacheBustingWorker support v2
This is amazing, thanks @sandermarechal @stof |
I second @Ninir. Thank you very much for this. |
@sandermarechal No, #119 was not enabling by default. |
@stof I know, that's why this one isn't either. But there were quite some people giving you a +1 for enabling it by default. That's what I meant. |
This is an updated version of #119, rebased on master and updated with regards to the changes in the CacheBustingWorker in assetic.