Skip to content

Commit

Permalink
feature #673 Upgrade from 3.3 to 3.4 & 4.0 (yceruto)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the master branch (closes #673).

Discussion
----------

Upgrade from 3.3 to 3.4 & 4.0

Remaining deprecation notices:

SwiftmailerBundle
---
- [x] <del>User Deprecated: The **"swiftmailer.mailer.default.plugin.messagelogger"** service is private, checking for its existence is deprecated since Symfony 3.2 and will fail in 4.0.</del>

- [x] <del>User Deprecated: The **"swiftmailer.mailer.default.plugin.messagelogger"** service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead. </del>

- [x] <del>User Deprecated: The **"mailer"** service is private, checking for its existence is deprecated since Symfony 3.2 and will fail in 4.0.</del>

- [x] <del>The **"swiftmailer.mailer.default.transport.real"** service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead.</del>

WhiteOctoberPagerfantaBundle
---
- [x] <del>User Deprecated: The **"white_october_pagerfanta.view_factory"** service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead.</del>

Symfony
---
- [x] <del>The **Symfony\Component\HttpFoundation\Session\Storage\Handler\NativeSessionHandler** class is deprecated since version 3.4 and will be removed in 4.0. Use the **\SessionHandler** class instead.</del>

- [x] <del>User Deprecated: The **Symfony\Component\HttpFoundation\Session\Storage\Proxy\SessionHandlerProxy** class is deprecated since version 3.4 and will be removed in 4.0. Use your session handler implementation directly.</del>

- [x] <del>User Deprecated: The **Symfony\Component\HttpFoundation\Session\Storage\Proxy\AbstractProxy** class is deprecated since version 3.4 and will be removed in 4.0. Use your session handler implementation directly.</del>

- [x] <del>User Deprecated: The **"Doctrine\DBAL\Configuration"** class is considered internal When adding a new configuration option just write a getter/setter pair and add the option to the _attributes array with a proper default value. It may change without further notice. You should not use it from **"Doctrine\ORM\Configuration"**.</del>

- [x] <del>Setting **logout_on_user_change** to false is deprecated as of 3.4 and will always be true in 4.0. Set **logout_on_user_change** to true in your firewall configuration. (isn't a blocker for 4.0)</del>

- [x] <del>Relying on service auto-registration for type **"App\Entity\Post"** is deprecated since version 3.4 and won't be supported in 4.0. Create a service named **"App\Entity\Post"** instead. (isn't a blocker for 4.0)</del>

- [x] <del>User Deprecated: The **"Symfony\Bridge\Doctrine\ManagerRegistry::setContainer()"** method is deprecated since version 3.4 and will be removed in 4.0. Inject a PSR-11 container using the constructor instead.</del>

Commits
-------

549ed2c Upgrade from 3.3 to 3.4 & 4.0
  • Loading branch information
javiereguiluz committed Nov 9, 2017
2 parents f76e900 + 549ed2c commit a3b4eae
Show file tree
Hide file tree
Showing 28 changed files with 1,419 additions and 1,226 deletions.
10 changes: 8 additions & 2 deletions .gitignore
@@ -1,7 +1,5 @@
/build/
/node_modules/
/phpunit.xml
/.php_cs
/var/*
!/var/cache
/var/cache/*
Expand All @@ -16,15 +14,23 @@
!var/SymfonyRequirements.php
/public/build/fonts/glyphicons-*
/public/build/images/glyphicons-*

###> symfony/framework-bundle ###
.env
/public/bundles/
/var/
/vendor/
###< symfony/framework-bundle ###

###> symfony/phpunit-bridge ###
/phpunit.xml
###< symfony/phpunit-bridge ###

###> symfony/web-server-bundle ###
.web-server-pid
###< symfony/web-server-bundle ###

###> friendsofphp/php-cs-fixer ###
.php_cs
.php_cs.cache
###< friendsofphp/php-cs-fixer ###
46 changes: 0 additions & 46 deletions Makefile

This file was deleted.

11 changes: 7 additions & 4 deletions bin/console
Expand Up @@ -3,11 +3,10 @@

use App\Kernel;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Component\Dotenv\Dotenv;
use Symfony\Component\Console\Input\ArgvInput;
use Symfony\Component\Debug\Debug;
use Symfony\Component\Dotenv\Dotenv;

umask(0000);
set_time_limit(0);

require __DIR__.'/../vendor/autoload.php';
Expand All @@ -24,8 +23,12 @@ $input = new ArgvInput();
$env = $input->getParameterOption(['--env', '-e'], $_SERVER['APP_ENV'] ?? 'dev');
$debug = ($_SERVER['APP_DEBUG'] ?? true) !== '0' && !$input->hasParameterOption(['--no-debug', '']);

if ($debug && class_exists(Debug::class)) {
Debug::enable();
if ($debug) {
umask(0000);

if (class_exists(Debug::class)) {
Debug::enable();
}
}

$kernel = new Kernel($env, $debug);
Expand Down
51 changes: 25 additions & 26 deletions composer.json
Expand Up @@ -6,39 +6,39 @@
"require": {
"php": "^7.1.3",
"ext-pdo_sqlite": "*",
"doctrine/doctrine-fixtures-bundle": "^2.3",
"doctrine/doctrine-fixtures-bundle": "^2.4",
"erusev/parsedown": "^1.6",
"ezyang/htmlpurifier": "^4.9",
"sensio/framework-extra-bundle": "^3.0",
"sensio/framework-extra-bundle": "^5.0",
"sensiolabs/security-checker": "^4.1",
"symfony/asset": "^3.3",
"symfony/expression-language": "^3.3",
"symfony/asset": "^4.0",
"symfony/expression-language": "^4.0",
"symfony/flex": "^1.0",
"symfony/form": "^3.3",
"symfony/framework-bundle": "^3.3",
"symfony/form": "^4.0",
"symfony/framework-bundle": "^4.0",
"symfony/monolog-bundle": "^3.1",
"symfony/orm-pack": "^1.0",
"symfony/polyfill-apcu": "^1.4",
"symfony/security-bundle": "^3.3",
"symfony/swiftmailer-bundle": "^3.0",
"symfony/translation": "^3.3",
"symfony/validator": "^3.3",
"symfony/yaml": "^3.3",
"symfony/polyfill-apcu": "^1.5",
"symfony/security-bundle": "^4.0",
"symfony/swiftmailer-bundle": "^3.1",
"symfony/translation": "^4.0",
"symfony/validator": "^4.0",
"symfony/yaml": "^4.0",
"twig/extensions": "^1.5",
"twig/twig": "^2.4",
"white-october/pagerfanta-bundle": "^1.0"
"white-october/pagerfanta-bundle": "^1.1"
},
"require-dev": {
"dama/doctrine-test-bundle": "^4.0",
"friendsofphp/php-cs-fixer": "^2.4",
"symfony/browser-kit": "^3.3",
"symfony/css-selector": "^3.3",
"symfony/debug-bundle": "^3.3",
"symfony/dotenv": "^3.3",
"symfony/phpunit-bridge": "^3.3",
"friendsofphp/php-cs-fixer": "^2.7",
"symfony/browser-kit": "^4.0",
"symfony/css-selector": "^4.0",
"symfony/debug-bundle": "^4.0",
"symfony/dotenv": "^4.0",
"symfony/phpunit-bridge": "^4.0",
"symfony/profiler-pack": "^1.0",
"symfony/var-dumper": "^3.3",
"symfony/web-server-bundle": "^3.3"
"symfony/var-dumper": "^4.0",
"symfony/web-server-bundle": "^4.0"
},
"config": {
"platform": {
Expand All @@ -61,19 +61,18 @@
},
"scripts": {
"auto-scripts": {
"make cache-warmup": "script",
"cache:clear": "symfony-cmd",
"assets:install --symlink --relative %PUBLIC_DIR%": "symfony-cmd",
"security-checker security:check": "script"
}
},
"conflict": {
"symfony/symfony": "*",
"symfony/twig-bundle": "<3.3",
"symfony/debug": "<3.3"
"symfony/symfony": "*"
},
"minimum-stability": "beta",
"extra": {
"symfony": {
"id": "",
"id": "01BY8QJHBGTYRP06WQFNY99EKP",
"allow-contrib": true
}
}
Expand Down

0 comments on commit a3b4eae

Please sign in to comment.