Skip to content

Commit

Permalink
bug #624 Fix some minor configuration issues (yceruto)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the master branch (closes #624).

Discussion
----------

Fix some minor configuration issues

* Use `public` instead of `web` as assets output path
* Exclude public/build from CS Fixer
* Fix comment indent

Commits
-------

9130656 Fix some minor configuration issues
  • Loading branch information
javiereguiluz committed Aug 30, 2017
2 parents 4af9be7 + 9130656 commit b610dc9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions .php_cs.dist
Expand Up @@ -14,9 +14,7 @@ $finder = PhpCsFixer\Finder::create()
->exclude('config')
->exclude('var')
->exclude('public/bundles')
->exclude('public/css')
->exclude('public/fonts')
->exclude('public/js')
->exclude('public/build')
;

return PhpCsFixer\Config::create()
Expand Down
2 changes: 1 addition & 1 deletion config/services.yaml
Expand Up @@ -32,7 +32,7 @@ services:
public: true
tags: ['controller.service_arguments']

# Autowiring can't guess the constructor arguments that are not type-hinted with
# Autowiring can't guess the constructor arguments that are not type-hinted with
# classes (e.g. container parameters) so you must define those arguments explicitly
App\Command\ListUsersCommand:
$emailSender: '%app.notifications.email_sender%'
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
@@ -1,7 +1,7 @@
var Encore = require('@symfony/webpack-encore');

Encore
.setOutputPath('web/build/')
.setOutputPath('public/build/')
.setPublicPath('/build')
.cleanupOutputBeforeBuild()
.autoProvidejQuery()
Expand Down

0 comments on commit b610dc9

Please sign in to comment.