Skip to content

Commit

Permalink
feature #1008 Be more specific in linting twig and yaml files (chr-he…
Browse files Browse the repository at this point in the history
…rtel)

This PR was merged into the master branch.

Discussion
----------

Be more specific in linting twig and yaml files

I would argue that adding those parameters ensures linting that is more similar to the framework runtime in production:
symfony will parse tags in config yaml files and twig runtime might differ between dev and prod environment.

for example we would catch a forgotten `{{ dump() }}` in a twig template that way

Commits
-------

11bcecf Be more specific in linting twig and yaml files
  • Loading branch information
javiereguiluz committed Jul 5, 2019
2 parents fed46b3 + 11bcecf commit b72b591
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ script:
# this checks that the source code follows the Symfony Code Syntax rules
- '[[ "$TRAVIS_PHP_VERSION" == "7.4snapshot" ]] || ./vendor/bin/php-cs-fixer fix --diff --dry-run -v'
# this checks that the YAML config files contain no syntax errors
- ./bin/console lint:yaml config
- ./bin/console lint:yaml config --parse-tags
# this checks that the Twig template files contain no syntax errors
- ./bin/console lint:twig templates
- ./bin/console lint:twig templates --env=prod
# this checks that the XLIFF translations contain no syntax errors
- ./bin/console lint:xliff translations
# this checks that the application doesn't use dependencies with known security vulnerabilities
Expand Down

0 comments on commit b72b591

Please sign in to comment.