Skip to content

Commit

Permalink
bug #1280 Assets manifest is not necessary with Webpack Encore (GromNaN)
Browse files Browse the repository at this point in the history
This PR was merged into the main branch.

Discussion
----------

Assets manifest is not necessary with Webpack Encore

Fix breaking changes introduced by #1278

Asset urls generated in `entrypoints.json` https://github.com/symfony/demo/blob/a7a975e2938b0568b493406ce914ac0866b6dd58/public/build/entrypoints.json#L13  are not meant to be mapped with `manifest.json`
https://github.com/symfony/demo/blob/a7a975e2938b0568b493406ce914ac0866b6dd58/public/build/manifest.json#L2

The only place where the twig `asset` function is used, is for a file that is not in the manifest: https://github.com/symfony/demo/blob/a7a975e2938b0568b493406ce914ac0866b6dd58/templates/base.html.twig#L17

Commits
-------

8e9facc Assets manifest is not necessary with Webpack Encore
  • Loading branch information
javiereguiluz committed Dec 7, 2021
2 parents 7e1a631 + 8e9facc commit c2315f7
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions config/packages/assets.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
framework:
assets:
json_manifest_path: '%kernel.project_dir%/public/build/manifest.json'
strict_mode: '%kernel.debug%'
assets: ~

0 comments on commit c2315f7

Please sign in to comment.