Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feature #576 Use 3.3 DI features in CodeExplorerBundle (ogizanagi)
This PR was merged into the master branch. Discussion ---------- Use 3.3 DI features in CodeExplorerBundle Since 3.3, [listeners do not have to be public anymore](https://github.com/symfony/symfony/pull/20953/files#diff-8604f72b4ae78c6c364c1af8c1dee17cL63). I also believe declaring services private by default by adding `_defaults: { public: false }` on top will become a best practice, so I think we should use it in the CodeExplorerBundle. Actually, we could also use classnamed services, autoconfigure and autowiring, but at least for the last one, I think we should keep a place in this application where services are declared entirely manually (autoconfigure is debatable this way too, that's true). WDYT? Commits ------- c391498 Use 3.3 DI features in CodeExplorerBundle
- Loading branch information