-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ircmaxell/password-compat as a dependency #10
Comments
Thanks for reporting this problem. I consider it a bug because we intend to support even PHP 5.3, so this problem shouldn't happen. And given that the We'll be very happy if you submit a PR with this change. Thanks! PS: I know that it may look weird, but in our composer.json file we sort dependencies alphabetically and align them with white spaces. Please keep in mind this weirdness when adding the new dependency. Thanks! |
looks like a good idea to me. Our demo should run on as many versions of PHP as possible to make it simpler to use. |
@javiereguiluz I would be in favor of removing the alignment for the same reason we don't align |
@stof 👍 |
I'm running the demo in 5.4 and when i go to the login page i get an error because the password_hash function doesn't exists in 5.4, we can add ircmaxell/password-compat as a dependency to solve this. if you are ok with this i can send a PR :)
PD: Sorry for my english, i'm noob
The text was updated successfully, but these errors were encountered: