Rebranded the application as "Symfony Demo" #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| <trans-unit id="title.homepage"> | |||
| <source>title.homepage</source> | |||
| <target><![CDATA[Добро пожаловать в <strong>Symfony Демо Приложение</strong>]]></target> | |||
| <target><![CDATA[Добро пожаловать в <strong>Symfony Demo</strong> Приложение]]></target> | |||
There was a problem hiding this comment.
Lowercase should be приложение.
|
@javiereguiluz Could you apply my notes about lowercase words? |
|
@bocharsky-bw done! Sorry for having changed this blindly and thanks for noticing me. |
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| <trans-unit id="title.homepage"> | |||
| <source>title.homepage</source> | |||
| <target><![CDATA[Willkommen zur <strong>Symfony Demo Application</strong>]]></target> | |||
| <target><![CDATA[Willkommen zur <strong>Symfony Demo</strong> applikation]]></target> | |||
There was a problem hiding this comment.
Though I think most Germans would use "Anwendung" or "Application".
There was a problem hiding this comment.
Thanks. I've changed it by Anwendung because it's the only one that looks like real German :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #85