Make Twig services and event listeners private #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Listeners cannot be private. they are access dynamically to lazy-load them (you should be getting an exception during the container building btw). @javiereguiluz what about enabling Travis on the repo to run the tests ? |
|
Thanks @bocharsky-bw for sending PRs, reviewing code and being so active on this repository! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 21, 2015
This PR was merged into the master branch. Discussion ---------- Make Twig services and event listeners private Thanks to stof in #104 (comment) Commits ------- 129960d Make Twig services and event listeners private
|
The markdown service should be private too btw, for the same reason than Twig extensions (it is only used as a dependency of the twig extension) |
|
@javiereguiluz you merged a broken PR |
|
You are right! It was fixed on 3608348 |
|
Travis is set up in the |
|
@fabpot can you enable Travis on this repo ? |
|
@stof and @javiereguiluz thank you! |
|
@stof done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to stof in #104 (comment)