-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Travis failure for PHP 5.6 #114
Conversation
👍 I almost made the same change in other PR and I was testing it irght now (https://github.com/javiereguiluz/symfony-demo/commit/bf799e4308035e7e07883e58d0628f6ea76c22b3) Thanks! |
Oh, now I see. :) |
I think I could close this PR |
Let's wait a bit ... neither your PR nor mine work at the moment :) |
@javiereguiluz The problem was I forgot to update |
@bocharsky-bw true! Should we remove the composer.lock file? In Travis the old problems with PHP 5.3 are gone, but now we have new problemas with 5.6 😠 |
No, The problem is we should always update dependencies when change |
The symfony-demo is a project, so we should indeed commit the lock file. See 0fd26c6#commitcomment-12339685 for the solution |
@stof thanks a lot for your help and for the explanation!! @bocharsky-bw please add the following in "config": {
"platform": {
"php": "5.3"
}
}, Besides, we can remove the |
I had next error for
so I bumped platform PHP version to |
@bocharsky-bw yes (and we should change the min version in the symfony-demo composer.json too) |
Still failed |
Looks like old version of |
@stof Thanks for your help! |
@bocharsky-bw great!!! We finally have green Travis results! Thank you! 🎉 🎉 🎉 |
No description provided.