Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis failure for PHP 5.6 #114

Closed
wants to merge 4 commits into from

Conversation

bocharsky-bw
Copy link
Contributor

No description provided.

@javiereguiluz
Copy link
Member

👍 I almost made the same change in other PR and I was testing it irght now (https://github.com/javiereguiluz/symfony-demo/commit/bf799e4308035e7e07883e58d0628f6ea76c22b3) Thanks!

@bocharsky-bw
Copy link
Contributor Author

Oh, now I see. :)

@bocharsky-bw
Copy link
Contributor Author

I think I could close this PR

@javiereguiluz
Copy link
Member

Let's wait a bit ... neither your PR nor mine work at the moment :)

@bocharsky-bw
Copy link
Contributor Author

@javiereguiluz The problem was I forgot to update composer.lock via $ composer update

@javiereguiluz
Copy link
Member

@bocharsky-bw true! Should we remove the composer.lock file? In Travis the old problems with PHP 5.3 are gone, but now we have new problemas with 5.6 😠

@bocharsky-bw
Copy link
Contributor Author

No, composer.lock file should be in the repo for same environment for all developers who use this repo.

The problem is we should always update dependencies when change composer.json file via command $ composer update. This command generate new composer.lock file with a new dependencies from changed composer.json.

@javiereguiluz
Copy link
Member

Let's ask for help to our friends @stof and @xabbuh to see if they can tweak the composer.json dependencies to fix Travis issues. Thanks!

@bocharsky-bw bocharsky-bw changed the title Fix Travis failure for legacy PHP 5.3 Fix Travis failure for legacy PHP 5.6 Jul 24, 2015
@bocharsky-bw bocharsky-bw changed the title Fix Travis failure for legacy PHP 5.6 Fix Travis failure for PHP 5.6 Jul 24, 2015
@stof
Copy link
Member

stof commented Jul 24, 2015

The symfony-demo is a project, so we should indeed commit the lock file. See 0fd26c6#commitcomment-12339685 for the solution

@javiereguiluz
Copy link
Member

@stof thanks a lot for your help and for the explanation!!

@bocharsky-bw please add the following in composer.json:

"config": {
        "platform": {
            "php": "5.3"
        }
    },

Besides, we can remove the doctrine/dbal dependency and we can simplify doctrine/orm to ~2.4.

@bocharsky-bw
Copy link
Contributor Author

I had next error for "platform": { "php": "5.3" } when did $ composer up:

  Problem 2
    - symfony/symfony v2.7.2 requires php >=5.3.9 -> your PHP version (5.6.4-4ubuntu6.2) does not satisfy that requirement.
    - symfony/symfony v2.7.2 requires php >=5.3.9 -> your PHP version (5.6.4-4ubuntu6.2) does not satisfy that requirement.
    - symfony/symfony v2.7.1 requires php >=5.3.9 -> your PHP version (5.6.4-4ubuntu6.2) does not satisfy that requirement.
    - symfony/symfony v2.7.0 requires php >=5.3.9 -> your PHP version (5.6.4-4ubuntu6.2) does not satisfy that requirement.
    - Installation request for symfony/symfony ~2.7 -> satisfiable by symfony/symfony[v2.7.0, v2.7.1, v2.7.2].

so I bumped platform PHP version to 5.3.9, it's ok?

@stof
Copy link
Member

stof commented Jul 24, 2015

@bocharsky-bw yes (and we should change the min version in the symfony-demo composer.json too)

@bocharsky-bw
Copy link
Contributor Author

Still failed

@bocharsky-bw
Copy link
Contributor Author

Looks like old version of Composer on Travis machine was a problem :(

@bocharsky-bw
Copy link
Contributor Author

@stof Thanks for your help!

@javiereguiluz
Copy link
Member

@bocharsky-bw great!!! We finally have green Travis results! Thank you! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants