Add tags to posts with many-to-many relation

[Rasanga]

This fixes #44 still need adding tags to admin back-end and I will work on that later.

Posts list view

Post show view

[voronkovich]

You should check whether the post already added, because Doctrine's collection doesn't do this. The same for the tag entity

[Rasanga]

so it would be as following?

if (false === $this->posts->indexOf($post)) {
$this->posts[] = $post;
}

[voronkovich]

It should look like this:

public function addTag(Tag $tag)
{
    if (!$this->tags->contains($tag)) {
        $this->tags->add($tag);
        $tag->addPost($this);
    }

    return $this;
}

public function removeTag(Tag $tag)
{
    if ($this->tags->contains($tag)) {
        $this->tags->removeElement($tag);
        $tag->removePost($this);
     }

    return $this;
}    

[Rasanga]

@voronkovich thanks, didn't think of contains(), I will amend the change

[voronkovich]

For example https://github.com/Sylius/Sylius/blob/master/src/Sylius/Component/Product/Model/Product.php#L269

[Rasanga]

nice example, thanks 👍

[stof]

using the reference system while being in the same fixture class is overkill: you don't clear the entity manager, so you could simply keep the same objects. Return an array of posts from this method, and pass them to the other method

[Rasanga]

Good thinking, for while I am wondering why aren't we using multiple fixture classes (fixture class for each entity class) in this example?

[Rasanga]

Fixed all issues mentioned in code review.

[xabbuh]

I think should put the if block around the paragraph to avoid rendering an empty one (the same can be done above).

[Rasanga]

I agree

[noniagriconomie]

What about updating the repository to load with tags? To avoid lazy loading
And btw, inform what is lazy loading :)

[versh23]

is it correct condition?

[voronkovich]

@versh23, no. It should be just $this->tags->removeElement($tag);, without any checkings because the removeElement function doesn't throw an exception when the element doesn't exist.

[javiereguiluz]

Closing it in favor of #447 and #448.