Add a complete test for AddUserCommand #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
force-pushed
the
add-command-test
branch
from
9bf8c8e
to
b48ab82
Compare
|
|
||
| $commandTester = new CommandTester($command); | ||
| $commandTester->setInputs($interactiveInputs); | ||
| $commandTester->execute(array_merge(['command' => $command->getName()], $inputArgs)); |
There was a problem hiding this comment.
Is the command argument required? I think we removed this in some past Symfony version ... but I could be perfectly wrong 😄
There was a problem hiding this comment.
You are absolutely right! 😄 👍 removed it.
dmaicher
force-pushed
the
add-command-test
branch
from
b48ab82
to
a08c746
Compare
dmaicher
commented
Mar 12, 2017
| $isAdmin ? ['--admin' => 1] : [], | ||
| // these are the responses given to the questions asked by the command | ||
| // to get the value of the missing required arguments | ||
| array_values($this->userdata) |
There was a problem hiding this comment.
@javiereguiluz $this->userData 😉
javiereguiluz
changed the title
|
Thanks @dmaicher. |
javiereguiluz
added a commit
that referenced
this pull request
Mar 12, 2017
…eguiluz) This PR was merged into the master branch. Discussion ---------- Add a complete test for AddUserCommand This adds a simple test for `AddUserCommand` that creates a user non-interactively and interactively. Fixes #473. Commits ------- 774adca Improved the PHPdoc of some methods c1d23f9 Fixed a variable name 3e15d59 Refactored the code and added some help notes a08c746 add simple test for AddUserCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple test for
AddUserCommandthat creates a user non-interactively and interactively.Fixes #473.