Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the demo application to Symfony 2.7 #72

Closed
wants to merge 7 commits into from
Closed

Updated the demo application to Symfony 2.7 #72

wants to merge 7 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #71

@xabbuh
Copy link
Member

xabbuh commented Jun 4, 2015

You should also commit the changes to the composer.json file.

@javiereguiluz
Copy link
Member Author

@xabbuh I did ... there is none :)

@xabbuh
Copy link
Member

xabbuh commented Jun 4, 2015

But there should be a difference if you bump the requirement to Symfony 2.7.

@javiereguiluz
Copy link
Member Author

@xabbuh in the .lock file yes, but not in the .json file (we use ~2.6 for Symfony)

@javiereguiluz
Copy link
Member Author

By the way, I updated Symfony following the recommendation of @weaverryan:

$ composer update symfony/symfony sensio/distribution-bundle --with-dependencies

@xabbuh
Copy link
Member

xabbuh commented Jun 4, 2015

To be more clear: You now make use of the configureOptions() method which introduced in Symfony 2.7. So having a version constraint like that if wing as you cannot use the form types with Symfony 2.6.

@javiereguiluz
Copy link
Member Author

OK. I understand you now :) Should I use 2.7.* or ~2.7?

@xabbuh
Copy link
Member

xabbuh commented Jun 4, 2015

Not sure if that really matters. What was the reasoning for the old constraint?

@javiereguiluz
Copy link
Member Author

There was no particular reasoning. I always use the ~ constraint, so let's keep using ~2.7. Thanks.

@stof
Copy link
Member

stof commented Jun 4, 2015

@javiereguiluz what about updating other deps too (DoctrineBundle got a new release for instance)

@javiereguiluz
Copy link
Member Author

@stof I fully agree! The constraint is now ~1.5 and I've executed composer update doctrine/doctrine-bundle --with-dependencies

The current constraints are as follows. Should we update any other dependency?

    "require": {
        "php"                                  : ">=5.3.3",
        "ext-pdo_sqlite"                       : "*",
        "doctrine/doctrine-bundle"             : "~1.5",
        "doctrine/doctrine-fixtures-bundle"    : "~2.2",
        "doctrine/orm"                         : "~2.2,>=2.2.3",
        "erusev/parsedown"                     : "~1.5",
        "incenteev/composer-parameter-handler" : "~2.0",
        "ircmaxell/password-compat"            : "~1.0",
        "leafo/scssphp"                        : "~0.1.",
        "patchwork/jsqueeze"                   : "~1.0",
        "sensio/distribution-bundle"           : "~3.0.12",
        "sensio/framework-extra-bundle"        : "~3.0",
        "symfony/assetic-bundle"               : "~2.3",
        "symfony/monolog-bundle"               : "~2.4",
        "symfony/swiftmailer-bundle"           : "~2.3",
        "symfony/symfony"                      : "~2.7",
        "twig/extensions"                      : "~1.0"
    },

@stof
Copy link
Member

stof commented Jun 4, 2015

Well, you should probably update all deps to their latest stable versions (incenteev/composer-parameter-handler has a new release too to avoid deprecation warnings on Symfony 2.7 for instance)

@javiereguiluz
Copy link
Member Author

OK then. I've updated everything to their latest versions.

@weaverryan
Copy link
Member

btw, we used the 2.6.* format in composer.json for symfony/symfony just to match the SE. But I don't think it's a problem to differ from it - as long as we're doing something "good" :).

@weaverryan
Copy link
Member

👍

@weaverryan
Copy link
Member

@javiereguiluz for the future - I had an idea. We could upgrade a branch of the symfony-demo during the stabilization phase of a Symfony version. Then, it'll be ready for the release. But more importantly, it might help identify any bugs or not-smooth upgrade paths, while those can still be fixed :).

@javiereguiluz
Copy link
Member Author

@weaverryan I like the idea and I'm going to implement it for 2.8. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update demo to SF 2.7
4 participants