Add check.php file for access from web #81
Conversation
I propose to get Symfony's `config.php` configurator file and rename it to `check.php` with some minor changes in order to get ability to check required and optional environment configuration parameters directly from web browser for success run this demo project. It's like `app/check.php` file for console, but allow users to check environment directly from web browser. I think it will be useful for beginners. What do you think, guys?
|
i think the symfony logo should be integrated |
|
@javiereguiluz Thanks a lot! I like it 👍 |
|
@OskarStark There is no Symfony's logo in P.S. I think Symfony's logo discussion could be open as a new issue. |
|
@OskarStark I think the Symfony logo should be reserved for the Symfony installation. This demo is independent from the framework, so I think we can change its design to match our styles. |
|
yes but the name |
|
@OskarStark let me put my reasoning in other words: this app is "made with Symfony" but "it's not Symfony". But let's see if other developers think we should add the logo. |
|
@javiereguiluz i understand your reasoning, but i think this is an app which shows best practices by the symfony community with standard symfony edition... so a logo makes it more clear.... before this pr there was a symfony logo, or? |
|
@bocharsky-bw I agree. Done. Thanks. |
|
@OskarStark I think better to create a new issue for this discussion about Symfony's logo in order to other developers could also tell their opinion. |
|
@javiereguiluz What about to add some instructions to |
|
@bocharsky-bw I like the idea a lot. Done in d88ef7b |
|
👍 for the note |
|
What about renaming the file to |
|
@xabbuh I think about it too, but there are no any config operations, only environment checks, so it seems to confused a bit as for me. |
|
This feature is now merged. Thank you @bocharsky-bw for starting it and thank you all for the reviews and the discussion! |
…iereguiluz) This PR was merged into the master branch. Discussion ---------- Add check.php file for access from web This PR takes the work made by @bocharsky-bw in #74 and applies the look-and-feel of the Symfony Demo application to better integrate it. ### No errors - Before  ### No errors - After  ### Errors - Before  ### Errors - After  Commits ------- d88ef7b Added a note about in the README about the new requirements checked 6972191 Minor change to allow sub-directory installation 2295159 Add check.php file for access from web 2128178 Add check.php file for access from web
This PR was squashed before being merged into the 4.0.x-dev branch (closes #217). Discussion ---------- Remove the web configurator I propose to remove the web configurator. Some arguments in favor of doing it: * It does two totally different things: check technical requirements and update the parameters file. * If we remove it, it's very easy to maintain the useful requirements checker (we already did this in the Symfony Demo application; see symfony/demo#81) * When it was created, it was truly useful. Nowadays, its usefulness is unclear. * It's incredibly overengineered (again, because it was created a very long time ago). * If we remove it, we'll have 25 less files to manage and more than 1,000 less lines of code. Commits ------- 0815bed Remove the web configurator
This PR takes the work made by @bocharsky-bw in #74 and applies the look-and-feel of the Symfony Demo application to better integrate it.
No errors - Before
No errors - After
Errors - Before
Errors - After