-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Why are assets enabled by default? #17
Comments
|
You are right. But Symfony Flex no longer makes assumptions about the app you develop (that's why we don't include a "Welcome Page" or the |
@javiereguiluz That's correct. This command could be moved from FrameworkBundle to elsewhere... but where? I didn't find a good place, that's why I kept it here. What we could do is to only enable it when there is at least one bundle with assets, but not sure if this could be practical or even desirable. WDYT? |
Perhaps considerable.. should SF offer this (frontend) solution at all? Looking at most of our projects today.. we dont really use/need it anymore since we moved to webpack and frontend specific commands/tasks (think gulp). For the same reason deprecating templating, classloader and such. We have better tools :) |
@ro0NL How do you let bundles expose some public assets then? |
@fabpot with such tools you don't have bundles that expose public assets. Everything is private and compiled by tools and task runners and dumped into the It's like if you have That's what I do for my projects, even for images, I'm using only Gulp with this Gulpfile which uses a simple configuration array and already has all needed preconfigured tasks for most cases, and I even use the I don't know about webpack, but it is basically the same thing: you specify your sources and dump the modules in the |
We dont :) well.. our gulp task just scrapes bundles, something like
But you really can do any setup you want. The current assets:install is more or less an opinionated setup, and can also be achieved writing a gulp task. I'm also thinking to move assets+templates from bundles to the app layer. Without assets:install there's no default strategy available for opensource bundles to reference owned assets in owned templates. But that's exactly one of my goals.. fully separate the view layer. And avoid depending on "global" templates and such... For webpack, we parse the generated
|
My 2 cents: Please do not increase the project setup cost and the learning curve height by introducing a requirement for external tools (especially node.js-based setups). Basic asset handling is great and there's nothing against replacing it in a project at will. |
Agee we can keep the current tooling available for basic asset handling, probably a lot of projects/bundles are using it. But @javiereguiluz has a point we should be able to decouple from it. A way to do it is to further strip down the framework bundle into smaller bundles, i.e. |
Same question for routing configuration. For cli-only application routing not needed |
@Koc the skeleton and the recipes are web-oriented. If you want to create a CLI tool, there is no need for anything. A regular composer req symfony/console is enough. |
we need doctrine infrstructure and httpplug |
Closing because this is not simple to fix (where should we move this into?) but it could be fixed in the future as explained by @ro0NL if Symfony code continues splitting the old FrameworkBundle into smaller pieces. Thanks! |
…aviereguiluz) This PR was squashed before being merged into the master branch (closes symfony#17). Discussion ---------- Proposed a help note for the DB_URL config format I'm not sure about this, but given that the URL format is so new to most developers, should we add a help note like this one? Commits ------- 193b15b Proposed a help note for the DB_URL config format
If I create a Symfony app with Flex and then install the
cli
package to access to Symfony commands, I see the following:Why is
assets:install
command enabled? I didn't expect to see it unless I enable/install assets support explicitly.The text was updated successfully, but these errors were encountered: