remove deprecated CURLPIPE_HTTP1 support flag #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 14, 2019
|
Thank you @hal869. |
fabpot
added a commit
that referenced
this pull request
Jun 15, 2019
This PR was merged into the 1.2-dev branch. Discussion ---------- remove deprecated CURLPIPE_HTTP1 support flag cref #515 @ https://curl.haxx.se/libcurl/c/CURLMOPT_PIPELINING.html ``` HTTP/1 Pipelining support was disabled in 7.62.0. ``` here ``` lsb_release -rd Description: openSUSE Leap 15.1 Release: 15.1 curl -V curl 7.65.1 (x86_64-suse-linux-gnu) libcurl/7.65.1 OpenSSL/1.1.0i-fips zlib/1.2.11 libidn2/2.2.0 ... ``` manually ``` src/CurlDownloader.php - curl_multi_setopt($mh, CURLMOPT_PIPELINING, /*CURLPIPE_HTTP1 | CURLPIPE_MULTIPLEX*/ 3); + curl_multi_setopt($mh, CURLMOPT_PIPELINING, /*CURLPIPE_MULTIPLEX*/ 2); ``` now, check ``` composer --version Composer version 1.8.6 2019-06-11 15:03:05 ``` Commits ------- 0fd8e9a remove deprecated CURLPIPE_HTTP1 support flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cref #515
@ https://curl.haxx.se/libcurl/c/CURLMOPT_PIPELINING.html
here
manually
now, check