Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reset-password] fix missing entity manager di #1017

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Nov 22, 2021

DI the EntityManagerInterface into the constructor as the private method is ultimately called in

return $this->processSendingPasswordResetEmail(
as well as the public reset method as well.

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We need a test for this, as this shouldn't have worked, but nothing failed. But I'll merge now so we can get this fix in a release

@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit 8ca25e0 into symfony:main Nov 22, 2021
@jrushlow jrushlow deleted the fix/missing-entity-manager branch May 3, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants