Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop symfony 4.4 support bump minimum Symfony version to 5.4.7 #1098

Merged
merged 1 commit into from
Apr 22, 2022
Merged

drop symfony 4.4 support bump minimum Symfony version to 5.4.7 #1098

merged 1 commit into from
Apr 22, 2022

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Apr 21, 2022 •
edited

  • MakerBundle Now supports Symfony >= 5.4.7
  • Minimum PHP Version >= 7.2.5
  • Removes legacy internal code
  • Reduces some Doctrine complexity (Leaves the door open to continue this effort in future PR's)
  • Fixes Issue with doctrine/orm 2.12.x #1090

@jrushlow jrushlow changed the title WIP - drop symfony 4.4 support WIP - drop symfony 4.4 support bump minimum Symfony version to 5.4.7 Apr 22, 2022
@jrushlow jrushlow added the Feature New Feature label Apr 22, 2022
@jrushlow jrushlow mentioned this pull request Apr 22, 2022
Closed
weaverryan
weaverryan reviewed Apr 22, 2022
View reviewed changes
.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@jrushlow jrushlow changed the title WIP - drop symfony 4.4 support bump minimum Symfony version to 5.4.7 drop symfony 4.4 support bump minimum Symfony version to 5.4.7 Apr 22, 2022
weaverryan
weaverryan reviewed Apr 22, 2022
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment - looks good 👍

src/Maker/MakeEntity.php Outdated Show resolved Hide resolved
@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit 5e93711 into symfony:main Apr 22, 2022
@jrushlow jrushlow deleted the support/drop-symfony-4.4 branch April 22, 2022 18:29
This was referenced Apr 22, 2022
Merged
Closed
@bobvandevijver
Copy link
Contributor

This MR actually made sure that the maker bundle is also no longer usable for Symfony 5.4. See #1102 for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan left review comments

Assignees
No one assigned
Labels
Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with doctrine/orm 2.12.x
3 participants
@jrushlow @weaverryan @bobvandevijver