[make:test] Removal of the condition requiring a php version < 8.1 #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
approved these changes
May 3, 2022
There was a problem hiding this comment.
Thank you @mdoutreluingne - I too cannot see why we have PHP 8.1 apart of this conditional..
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1092
Here I do not see why we must have a version of php < 8.1 . This is what was causing the problem it seems to me, the condition passed in the else, so users with a version of php > 8.1 and API platform 2.6 had the wrong class path (
ApiPlatform\Symfony\Bundle\Test\ApiTestCase).I think here we just need to know whether the class exists or not. Future versions of API platform will warn about deprecation of this wrong class path
ApiPlatform\Core\Bridge\Symfony\Bundle\Test\ApiTestCasefrom version 2.7 and become invalid in 3.0, as shown here .