Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors when enable_authenticator_manager is not set #1118

Merged
merged 1 commit into from May 17, 2022
Merged

Fix errors when enable_authenticator_manager is not set #1118

merged 1 commit into from May 17, 2022

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented May 13, 2022 •
edited

Fix errors when enable_authenticator_manager is not set and true is the default value (from Symfony 6)

Related to symfony/recipes#1085

@l-vo l-vo changed the title Fix error when enable_authenticator_manager is not set [WIP] Fix error when enable_authenticator_manager is not set May 13, 2022
@l-vo l-vo force-pushed the fix_error_when_authenticator_enabled_is_the_default branch from 03b4db3 to 1ca7b92 Compare May 16, 2022 08:41
@l-vo l-vo changed the title [WIP] Fix error when enable_authenticator_manager is not set Fix error when enable_authenticator_manager is not set May 16, 2022
@l-vo l-vo changed the title Fix error when enable_authenticator_manager is not set Fix errors when enable_authenticator_manager is not set May 16, 2022
@l-vo l-vo force-pushed the fix_error_when_authenticator_enabled_is_the_default branch from 1ca7b92 to 32c699c Compare May 16, 2022 09:01
@l-vo l-vo mentioned this pull request May 16, 2022
Merged
jrushlow
jrushlow requested changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for this @l-vo If you could add a couple legacy notations, we'll get this merged in!

src/Maker/MakeAuthenticator.php Show resolved Hide resolved
src/Maker/MakeRegistrationForm.php Show resolved Hide resolved
@jrushlow jrushlow added Bug Bug Fix Status: Needs Work Additional work is needed labels May 16, 2022
@l-vo
Fix errors when enable_authenticator_manager is not set
c950af3 
and true is the default value (from Symfony 6)
@l-vo l-vo force-pushed the fix_error_when_authenticator_enabled_is_the_default branch from 32c699c to c950af3 Compare May 16, 2022 19:05
@l-vo
Copy link
Contributor Author

l-vo commented May 16, 2022

@jrushlow legacy comments added 🙂

@l-vo
Copy link
Contributor Author

l-vo commented May 16, 2022

status: needs review

jrushlow
jrushlow approved these changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @l-vo

@jrushlow jrushlow added the Status: Reviewed Has been reviewed by a maintainer label May 17, 2022
@jrushlow jrushlow merged commit c35143f into symfony:main May 17, 2022
@jrushlow jrushlow removed the Status: Needs Work Additional work is needed label May 17, 2022
@l-vo l-vo deleted the fix_error_when_authenticator_enabled_is_the_default branch May 17, 2022 13:15
@jrushlow jrushlow mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@l-vo @jrushlow